Harden untrusted page-fetch and redirect boundaries - #3
Open
yinli-systems wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Search result URLs are untrusted. The previous
follow_redirects=Truefetch could request a redirect target without applying any destination policy, including a direct private or loopback address.Impact
Common direct and redirect-based local-network fetches now fail closed to the provider snippet without taking down retrieval. This is an application guard, not a replacement for a resolver-aware production egress proxy.
This branch intentionally does not duplicate open PR #1 (package discovery) or #2 (Tavily provider).
Checks
.venv/bin/python -m pytest -q tests— 83 passed, 1 dependency deprecation warning.venv/bin/python -m compileall -q fast_rag tests— passedgit diff --check— passed