Skip to content

Added additional keys to Message::getHeaders() to make full HTTP status line details available to Client::getHeaders().#205

Merged
terabytesoftw merged 8 commits intoyiisoft:masterfrom
zmoddynamics:204-extra-http-status-line-details
Feb 17, 2026
Merged

Added additional keys to Message::getHeaders() to make full HTTP status line details available to Client::getHeaders().#205
terabytesoftw merged 8 commits intoyiisoft:masterfrom
zmoddynamics:204-extra-http-status-line-details

Conversation

@zmoddynamics
Copy link
Contributor

@zmoddynamics zmoddynamics commented May 17, 2020

Adds 3 new header keys to $headerCollection.

  1. 'http-status-line': The full status line (ie. 'HTTP/1.1 200 OK')
  2. 'http-version': The http version returned from the server (ie. 'HTTP/1.1')
  3. 'http-status-code-reason-phrase': The status line without the HTTP version (ie. '200 OK')
Q A
Is bugfix? no
New feature? yes
Breaks BC? no
Tests pass? yes
Fixed issues #204

Adds 3 new header keys to $headerCollection.
1. 'http-status-line': The full status line (ie. 'HTTP/1.1 200 OK')
2. 'http-version': The http version returned from the server (ie. 'HTTP/1.1')
3.'http-status-code-reason-phrase': The status line without the HTTP version (ie. '200 OK')
@samdark samdark added this to the 2.0.13 milestone May 17, 2020
@samdark samdark added the pr:request for unit tests Unit tests are needed. label May 17, 2020
@yii-bot
Copy link

yii-bot commented May 17, 2020

Thank you for putting effort in the improvement of the Yii framework.
We have reviewed your pull request.

In order for the framework and your solution to remain stable in the future, we have a unit test requirement in place. Therefore we can only accept your pull request if it is covered by unit tests.

Could you add these please?

Thanks!

P.S. If you have any questions about the creation of unit tests? Don't hesitate to ask for support. More information about unit tests

This is an automated comment, triggered by adding the label pr:request for unit tests.

@samdark samdark modified the milestones: 2.0.13, 2.0.14 Dec 23, 2020
@samdark samdark removed this from the 2.0.14 milestone Aug 9, 2021
@codecov
Copy link

codecov bot commented Feb 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.17%. Comparing base (9e4b99a) to head (80aa005).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #205      +/-   ##
============================================
+ Coverage     98.14%   98.17%   +0.03%     
- Complexity      268      269       +1     
============================================
  Files            16       16              
  Lines           756      769      +13     
============================================
+ Hits            742      755      +13     
  Misses           14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@terabytesoftw terabytesoftw added the status:code review The pull request needs review. label Feb 14, 2026
@terabytesoftw terabytesoftw requested review from a team and samdark February 14, 2026 18:17
@terabytesoftw terabytesoftw linked an issue Feb 14, 2026 that may be closed by this pull request
@terabytesoftw terabytesoftw changed the title Enh #204 Added additional keys to Message::getHeaders() to make full HTTP status line details available to Client::getHeaders(). Feb 17, 2026
@terabytesoftw terabytesoftw merged commit 3e8bc25 into yiisoft:master Feb 17, 2026
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:request for unit tests Unit tests are needed. status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

More details on HTTP Status Line Header

6 participants