Added additional keys to Message::getHeaders() to make full HTTP status line details available to Client::getHeaders().#205
Conversation
Adds 3 new header keys to $headerCollection. 1. 'http-status-line': The full status line (ie. 'HTTP/1.1 200 OK') 2. 'http-version': The http version returned from the server (ie. 'HTTP/1.1') 3.'http-status-code-reason-phrase': The status line without the HTTP version (ie. '200 OK')
|
Thank you for putting effort in the improvement of the Yii framework. In order for the framework and your solution to remain stable in the future, we have a unit test requirement in place. Therefore we can only accept your pull request if it is covered by unit tests. Could you add these please? Thanks! P.S. If you have any questions about the creation of unit tests? Don't hesitate to ask for support. More information about unit tests This is an automated comment, triggered by adding the label |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #205 +/- ##
============================================
+ Coverage 98.14% 98.17% +0.03%
- Complexity 268 269 +1
============================================
Files 16 16
Lines 756 769 +13
============================================
+ Hits 742 755 +13
Misses 14 14 ☔ View full report in Codecov by Sentry. |
… add corresponding unit test.
Message::getHeaders() to make full HTTP status line details available to Client::getHeaders().
Adds 3 new header keys to $headerCollection.