Refactor font scaling and icon resolution in CompactView - #75
Merged
Conversation
…ved sticky width caching in CompactView
Contributor
Greptile SummaryThis PR refines CompactView font inheritance, sticky-width invalidation, and bundled icon resolution.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| contents/ui/CompactView.qml | Applies inherited font sizing without a self-referential family binding and resets grow-only width state when width-affecting settings change. |
| contents/ui/configGeneral.qml | Replaces a calculated guidance-text point size with the theme-provided small font. |
| contents/ui/configMetrics.qml | Resolves bundled metric icons to local SVG URLs consistently with runtime icon resolution. |
| contents/ui/main.qml | Represents the absence of an explicit configured font size as inherited sizing. |
Reviews (3): Last reviewed commit: "fix: resolve font family bindings, custo..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Use Kirigami.Theme.defaultFont.family as the fallback font to eliminate the self-referential font.family binding cycle. Update sticky width caching to follow a strict grow-only policy by removing the shrink threshold, preventing layout oscillations caused by fluctuating text metrics.
…reflow in CompactView - Bind font.family directly to compactRow.fontFamily across all delegates, breaking the self-referential binding cycle that triggered runtime QML loop warnings. - Decouple font family application from the customFont size check (effectiveFontSize > 0) to ensure a custom font family is not discarded when the user chooses the system-default font size. - Restrict _stickyWidth caching to only expand the cached width, ensuring the grow-only invariant is respected and eliminating reflow oscillations for fluctuating metrics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #74
Testing
install.sh