Add support for number of particles on PMSX003 devices - #1120
Open
ruimarinho wants to merge 1 commit into
Open
Conversation
ruimarinho
commented
Aug 9, 2018
| MAGNITUDE_PARTICLES_10 | ||
| } | ||
| }, | ||
| {"PMSX003_9", 9, 3, { |
ruimarinho
commented
Aug 9, 2018
| MAGNITUDE_PM2dot5, | ||
| MAGNITUDE_PM10 | ||
| }}, | ||
| {"PMS5003T", 13, 3, {MAGNITUDE_PM2dot5, MAGNITUDE_TEMPERATURE, MAGNITUDE_HUMIDITY}}, |
Contributor
Author
There was a problem hiding this comment.
@Yonsm could you check if these devices also support same readings?
ruimarinho
commented
Aug 9, 2018
| "PM1.0", "PM2.5", "PM10", "CO2", "Lux", "UV", "Distance" , "HCHO", | ||
| "PM1.0", "PM2.5", "PM10", | ||
| "Particles ≧0.3 ﹤0.5µm", "Particles ≧0.5 ﹤1µm", "Particles ≧1 ﹤2.5µm ", | ||
| "Particles ≧2.5 ﹤5µm", "Particles ≧5 ﹤10µm", "Particles ≧10µm", |
Contributor
Author
ruimarinho
force-pushed
the
support/number-of-particles-pmsx003
branch
from
August 9, 2018 01:00
9e1832b to
2a96ba7
Compare
ruimarinho
commented
Aug 9, 2018
| _slot_values[0] = data[3]; | ||
| _slot_values[1] = data[4]; | ||
| _slot_values[2] = data[5]; | ||
| _slot_values[3] = data[6] * 10; // convert particles per 0.1L of air to 1L |
Contributor
Author
Owner
There was a problem hiding this comment.
Yes, I understand the same, but you have defined the units per square meter of air when it should me per liter, so magnitude_particles_m3 should be magnitude_particles_l
xoseperez
requested changes
Aug 13, 2018
| _slot_values[0] = data[3]; | ||
| _slot_values[1] = data[4]; | ||
| _slot_values[2] = data[5]; | ||
| _slot_values[3] = data[6] * 10; // convert particles per 0.1L of air to 1L |
Owner
There was a problem hiding this comment.
Yes, I understand the same, but you have defined the units per square meter of air when it should me per liter, so magnitude_particles_m3 should be magnitude_particles_l
ruimarinho
force-pushed
the
support/number-of-particles-pmsx003
branch
2 times, most recently
from
August 15, 2018 23:29
03bec80 to
fa1a11d
Compare
Contributor
Author
|
@xoseperez fixed units - thanks. |
Contributor
Author
|
@xoseperez rebased and comments addressed. |
ruimarinho
force-pushed
the
support/number-of-particles-pmsx003
branch
from
November 2, 2018 00:49
fa1a11d to
29e30c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Tested on a PMS7003 device only.