Fix waterfall ImageItem mapping with setRect geometry (update_plot + recalculate_plot)#121
Open
makrohard wants to merge 1 commit intoxmikos:masterfrom
Open
Fix waterfall ImageItem mapping with setRect geometry (update_plot + recalculate_plot)#121makrohard wants to merge 1 commit intoxmikos:masterfrom
makrohard wants to merge 1 commit intoxmikos:masterfrom
Conversation
…-based geometry; sync update_plot and recalculate_plot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a waterfall failure caused by calling ImageItem.scale(x, y) during waterfall initialization
(TypeError: scale(self): too many arguments in some Qt/pyqtgraph stacks).
Instead of scaling/translating the ImageItem, the waterfall is mapped using setRect() in frequency/time coordinates.
The same mapping is applied in both update_plot() and recalculate_plot().
Tested on:
Related: #103, #108