Open
Conversation
previously missing keys with children were ignored in MapStruct marshal. this leads to missing values, and the code eventually panics in - chunkMap[name] = layout.PagesToChunk(pages) since pages is an empty slices in this case, and PagesToChunk assumes it has at least one element. the fix is to push to the stack all the missing keys in the map - - simple fields (without children) get a null value (as was done previously) - nested fields (with children) get an empty map value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previously, missing keys with children were ignored in MapStruct marshal. this leads to missing values, and the code eventually panics in -
chunkMap[name] = layout.PagesToChunk(pages)since
pagesis an empty slice in this case, andPagesToChunkassumes it has at least one element.the fix is to push to the stack all the missing keys in the map -
sample code that reproduces the issue -