Skip to content

feat: upgrade depends version. - #416

Merged
k82cn merged 2 commits into
xflops:mainfrom
k82cn:ver_upgrade
Apr 22, 2026
Merged

feat: upgrade depends version.#416
k82cn merged 2 commits into
xflops:mainfrom
k82cn:ver_upgrade

Conversation

@k82cn

@k82cn k82cn commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Klaus Ma <klausm@nvidia.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request performs a major dependency upgrade across the workspace, notably moving to Tonic 0.14, Prost 0.14, Arrow 58, and Thiserror 2. It updates the workspace resolver to version 2 and transitions gRPC code generation to use tonic-prost-build. Additionally, the Arrow IPC encoding logic in object_cache was refactored to accommodate API changes in version 58. I have no feedback to provide.

Signed-off-by: Klaus Ma <klausm@nvidia.com>
@codecov

codecov Bot commented Apr 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
object_cache/src/cache.rs 0.00% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

@k82cn
k82cn merged commit 3f463b8 into xflops:main Apr 22, 2026
6 of 7 checks passed
@k82cn
k82cn deleted the ver_upgrade branch April 22, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant