chore: perf of flamepy. - #412
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces several significant changes, including a transition from second-level to millisecond-level precision for timestamps across the RPC and storage layers, and the addition of comprehensive performance benchmarks for both Flame and Ray. It also refactors the Python SDK installation process to use a prefix-based approach and implements hash-based caching for package installations in the runner to improve startup performance. Key feedback points include the need to prepend rather than overwrite PYTHONPATH and LD_LIBRARY_PATH in the host shim to avoid conflicts with user-defined environments, cleaning up a redundant debug condition in the benchmark script, and reconsidering the use of the --no-deps flag during pip installation to ensure user package dependencies are correctly resolved.
| envs.entry("LD_LIBRARY_PATH".to_string()) | ||
| .or_insert(ld_paths.join(":")); |
There was a problem hiding this comment.
Similar to PYTHONPATH, LD_LIBRARY_PATH should be prepended rather than only inserted if missing. If a user provides their own LD_LIBRARY_PATH, the native extensions required by packages in the shim's site-packages might fail to load because their containing directories aren't in the search path.
let ld_paths_str = ld_paths.join(":");
envs.entry("LD_LIBRARY_PATH".to_string())
.and_modify(|e| *e = format!("{}:{}", ld_paths_str, e))
.or_insert(ld_paths_str);
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
20c411c to
660a42f
Compare
Signed-off-by: Klaus Ma <klausm@nvidia.com>
Signed-off-by: Klaus Ma <klausm@nvidia.com>
Signed-off-by: Klaus Ma <klausm@nvidia.com>
No description provided.