Conversation
5ec12fc to
94e18a9
Compare
|
fe5cbd3 to
94837e1
Compare
| Files.copy(response, tmpFile, StandardCopyOption.REPLACE_EXISTING); | ||
| } | ||
|
|
||
| return new ZipBlueprintArtifact(tmpFile); |
There was a problem hiding this comment.
Doesn't this need to have its reference overwritten? So that it correctly references the original resource, not the temporary file?
There was a problem hiding this comment.
This is handled in AbstractRemoteBlueprintArtifact, items loaded by load and loadAll are wrapped in a DelegateBlueprintArtifactItem. Since both S3BlueprintArtifact and ZipBlueprintArtifact extend AbstractRemoteBlueprintArtifact, the item will be wrapped twice (maybe not ideal, but it works).
|
NielsCW
changed the title
| testImplementation 'org.assertj:assertj-core' | ||
| testImplementation testFixtures(project(':contentgrid-appserver-blueprintartifact-impl-utils')) | ||
| testImplementation testFixtures(project(':contentgrid-appserver-contentstore-impl-utils')) | ||
| testImplementation "org.testcontainers:junit-jupiter" |
There was a problem hiding this comment.
Should be "org.testcontainers:testcontainers-junit-jupiter"
There was a problem hiding this comment.
Sorry, doesn't work in spring boot 3
3 participants
No description provided.