[codex] Fix stuck HUD after shortcut release#54
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #54 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 1252 1252
=========================================
Hits 1252 1252 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flagsChangedandkeyUprelease fallbacks active after the HUD is revealedCmd+Shift+letterpathRoot Cause
ShortcutCycle runs as an accessory app and shows the HUD in a non-activating panel. After reveal, the HUD was switching to local-only release monitoring. For shortcuts like
Cmd+Shift+JandCmd+Shift+A, local release delivery can be missed, which leaves the HUD visible until some later click changes state.Impact
This keeps the revealed HUD dismissible when the shortcut is released, instead of depending on a later click to recover.
Validation
swift test --filter PressAndHoldTests