Skip to content

[codex] Fix stuck HUD after shortcut release#54

Merged
xcv58 merged 2 commits intomasterfrom
codex/fix-stuck-hud-release
Apr 17, 2026
Merged

[codex] Fix stuck HUD after shortcut release#54
xcv58 merged 2 commits intomasterfrom
codex/fix-stuck-hud-release

Conversation

@xcv58
Copy link
Copy Markdown
Owner

@xcv58 xcv58 commented Apr 17, 2026

Summary

  • keep global flagsChanged and keyUp release fallbacks active after the HUD is revealed
  • add a regression test covering the revealed Cmd+Shift+letter path

Root Cause

ShortcutCycle runs as an accessory app and shows the HUD in a non-activating panel. After reveal, the HUD was switching to local-only release monitoring. For shortcuts like Cmd+Shift+J and Cmd+Shift+A, local release delivery can be missed, which leaves the HUD visible until some later click changes state.

Impact

This keeps the revealed HUD dismissible when the shortcut is released, instead of depending on a later click to recover.

Validation

  • swift test --filter PressAndHoldTests

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
shortcut-cycle Ready Ready Preview, Comment Apr 17, 2026 9:04pm

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (4aec2b8) to head (db7ebdf).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #54   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines         1252      1252           
=========================================
  Hits          1252      1252           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xcv58 xcv58 marked this pull request as ready for review April 17, 2026 22:05
@xcv58 xcv58 merged commit 686ae51 into master Apr 17, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant