Open
Conversation
glehmann
force-pushed
the
gln/misc-typehints
branch
from
c32f1f4 to
2ffd7ed
Compare
glehmann
force-pushed
the
gln/xapi-network-typehints
branch
from
b3d821d to
7b59763
Compare
semarie
approved these changes
Feb 16, 2026
| logging.info(f"Check that the host certificate exists on host {h}") | ||
| cert_uuid = hostA1.xe('certificate-list', {'host': h.uuid, 'type': 'host_internal'}, minimal=True) | ||
| assert len(cert_uuid) > 0, f"A host_internal certificate must exist on host {h}" | ||
| yield hostA1 |
Contributor
There was a problem hiding this comment.
I agree that yielding hostA1 is the intented purpose of the fixture.
The current code relies only on the side effect to ensuring that TLS verification is enabled (using assert), but it could be changed (later) to really use the fixture (instead of marking it used and use hostA1).
Fine with me as it.
glehmann
force-pushed
the
gln/misc-typehints
branch
from
2ffd7ed to
86cb57e
Compare
glehmann
force-pushed
the
gln/xapi-network-typehints
branch
from
7b59763 to
50754ce
Compare
Member
|
Do the changes require running a few tests to verify everything works well, or are they riskless? |
glehmann
force-pushed
the
gln/misc-typehints
branch
from
86cb57e to
a5a4abb
Compare
glehmann
force-pushed
the
gln/xapi-network-typehints
branch
2 times, most recently
from
4c9b247 to
7b6389e
Compare
glehmann
force-pushed
the
gln/misc-typehints
branch
2 times, most recently
from
1488c49 to
99bce99
Compare
glehmann
force-pushed
the
gln/xapi-network-typehints
branch
from
7b6389e to
6c7b248
Compare
glehmann
force-pushed
the
gln/misc-typehints
branch
from
99bce99 to
47c708a
Compare
glehmann
force-pushed
the
gln/xapi-network-typehints
branch
from
6c7b248 to
1c70a06
Compare
glehmann
force-pushed
the
gln/xapi-network-typehints
branch
from
1c70a06 to
e712aec
Compare
glehmann
force-pushed
the
gln/misc-typehints
branch
from
47c708a to
ba07031
Compare
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
Signed-off-by: Gaëtan Lehmann <gaetan.lehmann@vates.tech>
glehmann
force-pushed
the
gln/xapi-network-typehints
branch
from
e712aec to
b383dfa
Compare
glehmann
force-pushed
the
gln/misc-typehints
branch
from
ba07031 to
4a34482
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows more validation both in the CI and when writing the tests in our IDEs.
This work was mostly done with AI, validated by the code checkers, and manually cleaned up by me.