Conversation
Kodiai Review SummaryWhat ChangedFixes several broken lyrics scrapers (genius, musixmatch, supermusic, darklyrics) by updating HTML parsing patterns and switching to new API endpoints. Reviewed: core logic, docs Strengths
ObservationsImpact[MAJOR] script.cu.lrclyrics/lib/culrcscrapers/genius/lyricsScraper.py (40): Hard-coded array index causes crash when API response structure differs [MAJOR] script.cu.lrclyrics/lib/culrcscrapers/supermusic/lyricsScraper.py (80): Copy-paste error fetches wrong URL in retry logic [MAJOR] script.cu.lrclyrics/lib/culrcscrapers/supermusic/lyricsScraper.py (85): Missing null check on BeautifulSoup find result Verdict🔴 Address before merging -- 3 blocking issue(s) found Review Details
Files not fully reviewed (sorted by risk score)
|
c27b00f to
d4ac5ad
Compare
|
fixes issues found by AI (nice feature btw) |
d4ac5ad to
923dfca
Compare
this update fix several broken scrapers.
Description
Checklist:
Additional information :