Fix crash caused by stale hNtdllFile handle on NtClose (#172)#174
Open
ali-asly101 wants to merge 2 commits intox64dbg:masterfrom
Open
Fix crash caused by stale hNtdllFile handle on NtClose (#172)#174ali-asly101 wants to merge 2 commits intox64dbg:masterfrom
ali-asly101 wants to merge 2 commits intox64dbg:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #172
When
NtCloseis called on the handle saved byHookedNtOpenFile,hNtdllFilewas not being reset. This causedHookedNtCreateSectionto match against a recycled handle value, mapping the wrong DLL and crashing inDestroyMappedNtApi.The same issue could occur with
hNtdllSectionif the section handle was closed beforeNtMapViewOfSection.Fix: Clear
hNtdllFileandhNtdllSectioninHookedNtClosewhen the tracked handle is closed. Moved both global declarations to the top of the file so they are visible toHookedNtClose.Tested: Reproduced the crash using a test program that forces handle reuse via
NtOpenFile/NtCloseloop. After the fix, the test exits cleanly with no access violation.