fix(a11y): name NotificationPanel drawer and announce new items - #568
Merged
Conversation
… better synchronization and state management
…vior and state management
3 tasks
📝 WalkthroughWalkthrough
Sequence Diagram(s)sequenceDiagram
participant Consumer
participant NotificationPanel
participant Context
participant PoliteLiveRegion
Consumer->>NotificationPanel: Provide liveAnnouncement
NotificationPanel->>Context: Expose open and setLiveAnnouncement
NotificationPanel->>PoliteLiveRegion: Render announcement while open
Consumer->>Context: Call setLiveAnnouncement(message)
Context->>NotificationPanel: Publish message
NotificationPanel->>PoliteLiveRegion: Remount updated status text
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
sm1990
reviewed
Jul 24, 2026
sm1990
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Name the NotificationPanel drawer for assistive tech and add a polite live region for consumer-published status updates (WCAG 4.1.2 / 4.1.3).
aria-label="Notifications"(overridable; empty/whitespace falls back)liveAnnouncement/setLiveAnnouncement(list child-count is not auto-announced)undefined; do not re-announce unchanged prop on reopenRelated Issues
Related PRs
Checklist
packages/oxygen-ui-docs/ACCESSIBILITY.md, NotificationPanel + Accessibility stories)packages/oxygen-ui/src/components/accessibility.test.tsx)Security checks