Add key store & trust store type in the connection config#267
Open
kalaiyarasiganeshalingam wants to merge 2 commits intowso2-extensions:4.0.xfrom
Open
Add key store & trust store type in the connection config#267kalaiyarasiganeshalingam wants to merge 2 commits intowso2-extensions:4.0.xfrom
kalaiyarasiganeshalingam wants to merge 2 commits intowso2-extensions:4.0.xfrom
Conversation
arunans23
reviewed
Nov 20, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for configuring keystore and truststore types in FTPS connections, allowing users to specify the type of keystore (e.g., JKS, PKCS12) alongside the existing path and password configurations.
- Added
keyStoreTypeandtrustStoreTypeparameters across all configuration layers - Updated commons-vfs dependency to version
2.2.0-wso2v23-SNAPSHOTto support the new type configuration methods - Maintained consistency with existing keystore/truststore configuration patterns
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/resources/uischema/ftps.json | Added UI schema definitions for keyStoreType and trustStoreType fields with appropriate validation and help text |
| src/main/resources/config/init.xml | Added parameter definitions for keyStoreType and trustStoreType in the connector template |
| src/main/java/org/wso2/carbon/connector/utils/Const.java | Added constants KEYSTORE_TYPE and TRUSTSTORE_TYPE for parameter name references |
| src/main/java/org/wso2/carbon/connector/pojo/FTPSConnectionConfig.java | Added private fields and getter/setter methods for keyStoreType and trustStoreType with empty check validation |
| src/main/java/org/wso2/carbon/connector/operations/FileConfig.java | Added parameter retrieval and configuration setting for keyStoreType and trustStoreType from message context |
| src/main/java/org/wso2/carbon/connector/connection/FTPSFileSystemSetup.java | Added calls to FtpsFileSystemConfigBuilder to set keystore and truststore types when values are provided |
| pom.xml | Updated commons-vfs version to 2.2.0-wso2v23-SNAPSHOT to support the new keystore/truststore type configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
$Subject