ci: Improve performance of go lint and formatting#4831
Draft
johnsaigle wants to merge 1 commit into
Draft
Conversation
johnsaigle
marked this pull request as ready for review
May 21, 2026 18:42
johnsaigle
requested review from
SEJeff,
djb15,
evan-gray,
kcsongor and
panoel
as code owners
May 21, 2026 18:42
djb15
previously approved these changes
Jun 4, 2026
johnsaigle
force-pushed
the
ci-improve-lint-performance
branch
from
June 16, 2026 14:16
77e5814 to
dcd1234
Compare
johnsaigle
force-pushed
the
ci-improve-lint-performance
branch
from
June 16, 2026 15:01
dcd1234 to
4920f7e
Compare
- use git ls-files instead of find - Allow parallel golangci-lint runs so node/ and sdk/ run at the same time
johnsaigle
force-pushed
the
ci-improve-lint-performance
branch
from
June 16, 2026 18:33
4920f7e to
ac7d5ae
Compare
djb15
approved these changes
Jun 17, 2026
johnsaigle
marked this pull request as draft
June 18, 2026 18:52
Contributor
Author
|
Moving to draft mode for the moment so that we can merge in #4841 first. I'll come back to this afterward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git ls-filesto retrieve check-in Go files for linting. This should be faster than usingfindto traverse all the subdirs and look up OS information.