chore(builder): add ability to limit uncompressed block size#441
chore(builder): add ability to limit uncompressed block size#441alessandromazza98 merged 5 commits intomainfrom
Conversation
alessandromazza98
requested review from
0xForerunner,
0xOsiris,
Dzejkop,
cichaczem,
karankurbur,
kilianglas,
murph and
piohei
as code owners
alessandromazza98
force-pushed
the
ale/limit-uncompressed-blocks
branch
from
ba91e2a to
a560fb5
Compare
|
Note that foundry CI is not working due to an external and temporary problem (I think rate limiting) that is definitely not related to this PR, so we can safely ignore it |
0xForerunner
left a comment
0xForerunner
left a comment
There was a problem hiding this comment.
Looks great, nice work!
crates/world/node/src/args.rs
Outdated
| pub tx_peers: Option<Vec<PeerId>>, | ||
|
|
||
| /// Maximum cumulative uncompressed (EIP-2718 encoded) block size in bytes | ||
| #[arg(long)] |
There was a problem hiding this comment.
Actually can we please add long = "block-uncompressed-size-limit"
There was a problem hiding this comment.
as well as env ="BLOCK_UNCOMPRESSED_SIZE_LIMIT"
There was a problem hiding this comment.
by default it's like this if nothing is provided
There was a problem hiding this comment.
Actually, now that I think about it this should be in the builder args
long = "builder.block-uncompressed-size-limit"
env ="BUILDER_BLOCK_UNCOMPRESSED_SIZE_LIMIT"
There was a problem hiding this comment.
by default it's like this if nothing is provided
ah I thought clap defaulted to snake. TIL!
There was a problem hiding this comment.
done btw, I've added it to builder args
crates/world/node/src/args.rs
Outdated
| pub tx_peers: Option<Vec<PeerId>>, | ||
|
|
||
| /// Maximum cumulative uncompressed (EIP-2718 encoded) block size in bytes | ||
| #[arg(long)] |
There was a problem hiding this comment.
as well as env ="BLOCK_UNCOMPRESSED_SIZE_LIMIT"
crates/world/node/src/args.rs
Outdated
| pub tx_peers: Option<Vec<PeerId>>, | ||
|
|
||
| /// Maximum cumulative uncompressed (EIP-2718 encoded) block size in bytes | ||
| #[arg(long)] |
There was a problem hiding this comment.
Actually, now that I think about it this should be in the builder args
long = "builder.block-uncompressed-size-limit"
env ="BUILDER_BLOCK_UNCOMPRESSED_SIZE_LIMIT"
|
We should probably also add a |
2 participants
Description
Add the ability to limit max uncompressed block size in the builder.