Universal Add Factor #136
Open
Universal Add Factor #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukejmann
requested review from
aurel-fr,
murph,
paolodamico and
thomas-waite
as code owners
aurel-fr
reviewed
Oct 17, 2025
| return Err(BackupManagerError::ETagNotFound); | ||
| }; | ||
|
|
||
| metadata.keys.push(encryption_key); |
Contributor
There was a problem hiding this comment.
shouldn't we check if the key already exist and skip if it does?
| } | ||
| } | ||
| // best-effort cleanup if we inserted lookup above when not needed | ||
| let _ = factor_lookup |
Contributor
There was a problem hiding this comment.
we don't first check lookup_insert_succeeded before the cleanup here?
| ) | ||
| .await?; | ||
| ( | ||
| serde_json::Value::String(STANDARD.encode(new_factor_challenge)), |
Contributor
There was a problem hiding this comment.
Some parts of the code we use STANDARD others URL_SAFE_NO_PAD. It'd be simpler to settle on one flavor.
paolodamico
reviewed
Oct 18, 2025
| /// # Errors | ||
| /// - `BackupManagerError::BackupNotFound` - if the backup does not exist. | ||
| /// - `BackupManagerError::ETagNotFound` - if `ETag` is missing (unexpected). | ||
| pub async fn add_encryption_key_only( |
| new_factor: NewFactor, | ||
| /// Optional; defaults to PASSKEY to preserve current clients | ||
| #[serde(default)] | ||
| existing_factor_kind: Option<ExistingFactorKind>, |
Contributor
There was a problem hiding this comment.
I wonder if we really need this and we need to distinguish the challenge_type in the challenge_token. I don't think having that is adding much. thoughts @aurel-fr too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the universal add factor feature described here: https://www.notion.so/worldcoin/Backup-Service-Universal-Add-Factor-Proposal-2548614bdf8c80b5a872c3a08d43ed67?source=copy_link
tldr: we extend the add_factor flow to include all factor combinations, not just passkey->oidc