fix: add null guards for getItemOptionData()->getValues() calls#482
Open
slash1andy wants to merge 2 commits intowoocommerce:trunkfrom
Open
fix: add null guards for getItemOptionData()->getValues() calls#482slash1andy wants to merge 2 commits intowoocommerce:trunkfrom
slash1andy wants to merge 2 commits intowoocommerce:trunkfrom
Conversation
Three locations in API.php call getItemOptionData()->getValues() without checking for null, crashing sync jobs when Square returns ITEM_OPTION objects with null item_option_data. Apply the same guard pattern already used in Product_Import.php (lines 789 and 894). Fixes SQUARE-292.
The update_catalog_variation() method calls getItemOptionData()->getValues() without checking for null, matching the same pattern fixed in API.php. Part of SQUARE-292.
iamdharmesh
approved these changes
Apr 8, 2026
Collaborator
iamdharmesh
left a comment
There was a problem hiding this comment.
Thanks @slash1andy. Looks good to me.
faisal-alvi
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three locations call
getItemOptionData()->getValues()on SquareCatalogObjectinstances without checking whethergetItemOptionData()returns null. The Square SDK types this return as?CatalogItemOption— explicitly nullable.If Square returns an
ITEM_OPTIONobject with nullitem_option_data:\Error, which is not caught bycatch (\Exception)inStepped_Job::do_next_step()Either way, the entire Action Scheduler job crashes with no recovery path.
Fix
Applied the same null guard pattern already used in
Product_Import.php(lines 789 and 894):Locations fixed
includes/API.phpretrieve_options_data()includes/API.phpcreate_options_and_values()includes/API.phpcreate_options_and_values()includes/Handlers/Product/Woo_SOR.phpupdate_catalog_variation()Test plan
item_option_data) without crashingFixes SQUARE-292.