Missing shipping address validation not triggering requires additional information status (5867)#4109
Open
mmaymo wants to merge 5 commits intodev/PCP-4891-agentic-commercefrom
Conversation
mmaymo
requested review from
AlexP11223,
Dinamiko,
Narek13,
danieldudzic,
hmouhtar and
stracker-phil
as code owners
danieldudzic
requested changes
Feb 26, 2026
Collaborator
danieldudzic
left a comment
danieldudzic
left a comment
There was a problem hiding this comment.
Thanks for working on this! 🙏
We should re-sync this with the parent, and I also left a note regarding the recent refactor of Resolution Options, which this should probably also follow.
modules/ppcp-store-sync/src/CartValidation/ShippingValidator.php
Outdated
Show resolved
Hide resolved
…ipping-address-validation-not-triggering-requires-additional-information-status
danieldudzic
requested changes
Feb 27, 2026
Collaborator
danieldudzic
left a comment
danieldudzic
left a comment
There was a problem hiding this comment.
Nice! Got 2 super minor change requests 🙏
Co-authored-by: Danny Dudzic <d.dudzic@syde.com>
danieldudzic
approved these changes
Mar 2, 2026
Collaborator
danieldudzic
left a comment
danieldudzic
left a comment
There was a problem hiding this comment.
This is good to go! cc: @stracker-phil
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Steps to Test
This PR takes https://github.com/woocommerce/woocommerce-paypal-payments/tree/dev/PCP-5707-rename-to-store-sync as reference