[WOOMOB-3477] Migrate dashboard content to Store Design System#16248
Conversation
Generated by 🚫 Danger |
|
|
| android:layout_height="match_parent" | ||
| android:animateLayoutChanges="true" | ||
| android:background="@color/color_surface" | ||
| android:background="@color/woo_ds_color_background_section" |
There was a problem hiding this comment.
The Dashboard root already painted a background before this PR; this change only updates it to the DS section color. The background is intentionally retained for the hybrid XML/Compose shell and exposed JITM margins. Removing the Activity window background safely would require broader MainActivity-level work, so we are retaining this behavior here.
c5bb05e to
6860232
Compare
6860232 to
2447c7d
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## trunk #16248 +/- ##
============================================
- Coverage 41.15% 40.94% -0.21%
Complexity 13498 13498
============================================
Files 2503 2507 +4
Lines 146462 147198 +736
Branches 21761 21916 +155
============================================
Hits 60275 60275
- Misses 80089 80825 +736
Partials 6098 6098 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2447c7d to
6d9c166
Compare
6d9c166 to
5d0e6cd
Compare
5d0e6cd to
6a818ed
Compare
There was a problem hiding this comment.
AI Code Review - No issues found. The changes look good.
This is a clean, largely mechanical migration of the My Store dashboard from Material to Material3 / the Woo Design System. I verified the theme boundaries: the new Material3 OrderSummaryRow/ProductSummaryRow (which now read WooTheme.* composition locals) are only used from WooDesignSystemTheme-rooted screens (the dashboard), while the AI Assistant renderers were correctly moved to the new LegacyOrderSummaryRow/LegacyProductSummaryRow variants and POS uses its own local OrderSummaryRow — so there is no risk of a missing-CompositionLocal crash. Public composable signatures are preserved.
The two bot-flagged Lint items (root-background overdraw on fragment_dashboard.xml, and material/material3 mixing inside the new Legacy* files) were already reviewed and explicitly accepted by a repo maintainer as intentional legacy behavior, so I have not re-raised them.
PR housekeeping
- Applied repo
AGENTS.md/CLAUDE.mdguidance (store vs. POS architecture boundaries) when verifying theme usage.
Automatic review · claude-opus-4-8 · Workflow run
How to reply to a finding
Reply on this review (or inline at the line the finding refers to) with one of:
@claude addressed- I made the change. Bot verifies against the next diff before marking resolved.@claude rejected: <reason>- Will not fix; reason gets quoted on the next review.@claude not-applicable- Finding does not apply (wrong file, already covered elsewhere, etc.).
The bot honours these on the next review pass.
There was a problem hiding this comment.
Screen_recording_20260720_222805.webm
I noticed an issue occurring when placing the app in the background and opening it again while in a scrolled state. You can see in the video that the store name disappears in this case. I noticed the top bar was changed in a follow-up PR. So ignore this.
In the screenshot above, you can see that the two “i” icons have different colors. They were the same on trunk.
| Before | After |
|---|---|
![]() |
![]() |
I think we need more contrast between the context menu and the card background.
|
Thanks @irfano for the review.
Like all design system PRs, please ignore dark color issues for now, until we update our color foundations. I will check and reply to the other comments. |
6a818ed to
4f33991
Compare
|
@irfano Fixed the information-icon color mismatch in |
30dc14e
into
feature/store-design-system-migration



Description
Part of WOOMOB-3477 — does not close the ticket.
This PR migrates the My Store dashboard content area and cards to the Store Design System while preserving the existing Fragment-hosted top app bar.
It:
Remaining work for WOOMOB-3477: migrate the top app bar, then move the Customize action from the toolbar to the bottom position shown in Figma.
Test Steps
Images/gif
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.