Extract shared WooPosOrderCreatedData to remove duplicated types#15604
Merged
malinajirka merged 6 commits intotrunkfrom Apr 6, 2026
Merged
Extract shared WooPosOrderCreatedData to remove duplicated types#15604malinajirka merged 6 commits intotrunkfrom
malinajirka merged 6 commits intotrunkfrom
Conversation
Extract ProductInfo and CouponInfo data classes into a standalone shared file so both ChildToParent and ParentToChildren event hierarchies can reference the same types.
Both ChildToParentEvent.OrderCreated and ParentToChildrenEvent.OrderCreated had identical ProductInfo and CouponInfo hierarchies, forcing a boilerplate mapping function in HomeViewModel. Now both events wrap the single shared WooPosOrderCreatedData, removing ~100 lines of duplication and mapping code.
Collaborator
|
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## trunk #15604 +/- ##
============================================
- Coverage 39.64% 39.64% -0.01%
- Complexity 11357 11358 +1
============================================
Files 2259 2260 +1
Lines 130543 130492 -51
Branches 18284 18283 -1
============================================
- Hits 51756 51728 -28
+ Misses 73502 73479 -23
Partials 5285 5285 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
[Internal] Extract
ProductInfoandCouponInfodata classes from the duplicatedOrderCreatedevent definitions into a sharedWooPosOrderCreatedDataclass.Both
ChildToParentEvent.OrderCreatedandParentToChildrenEvent.OrderCreatedhad identicalProductInfo(Simple + Variation) andCouponInfohierarchies defined independently. This forced a 37-line boilerplate mapping function (handleOrderCreated) inWooPosHomeViewModelthat copied every field one-by-one between the two identical types.Now both events wrap a single
WooPosOrderCreatedData, eliminating the duplication and the mapping code entirely.Test Steps
Images/gif
N/A — no UI changes.
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.