Conversation
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #15587 +/- ##
=========================================
Coverage 39.62% 39.62%
- Complexity 11336 11338 +2
=========================================
Files 2260 2260
Lines 130597 130605 +8
Branches 18302 18304 +2
=========================================
+ Hits 51753 51758 +5
- Misses 73555 73557 +2
- Partials 5289 5290 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AdamGrzybkowski
left a comment
There was a problem hiding this comment.
Looks good! One question though - couldn't the backend simply filter out FedEx until its ready? 🤔
| AGE_ELIGIBILITY_CHECKS("age_eligibility_checks", localValue = PackageUtils.isDebugBuild()), | ||
| WOO_SELF_DRIVEN_PUSH_NOTIFICATIONS_M1("woo_self_driven_push_notifications_m1", localValue = false), | ||
| WOO_SELF_DRIVEN_PUSH_NOTIFICATIONS_M2("woo_self_driven_push_notifications_m2", localValue = false), | ||
| WOO_SHIPPING_FEDEX("woo_shipping_fedex", localValue = false), |
There was a problem hiding this comment.
❓ Any reasons for not taking advantage of the new unified feature flag handling and setting the local value to true while disabling the feature remotely? Is there any benefit of having it done in a way that requires an extra app update?
|
@irfano Should this PR target 24.4? |

Description
Fixes WOOMOB-2574
Disables FedEx in the Android shipping labels flow behind a temporary feature flag.
This hides FedEx in both the package carrier tabs and the shipping rates flow while the mobile support remains turned off.
Slack discussion:
Test Steps
Carriertab.Images/gif
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.