[Hack Week] Add products check to the troubleshooting tool#15584
Draft
hichamboushaba wants to merge 6 commits intohack-week/improve-troubleshooting-screenfrom
Draft
[Hack Week] Add products check to the troubleshooting tool#15584hichamboushaba wants to merge 6 commits intohack-week/improve-troubleshooting-screenfrom
hichamboushaba wants to merge 6 commits intohack-week/improve-troubleshooting-screenfrom
Conversation
Collaborator
Generated by 🚫 Danger |
Collaborator
|
|
f594d3e to
a9027ed
Compare
Add StoreProductsCheckUseCase that fetches products via WCProductStore and maps errors to appropriate FailureTypes. Integrate the new check into the connectivity tool state machine, view model, and UI.
Add StoreProductsCheckUseCaseTest covering success, timeout, parse, jetpack, and generic error scenarios. Update OrderConnectivityToolViewModelTest to include the products check mock and add a dedicated test case.
Add VALUE_CONNECTIVITY_PRODUCTS to the connectivity tool section of AnalyticsTracker instead of reusing the onboarding VALUE_PRODUCTS. Add ViewModel test for products check failure terminating the flow.
Use dedicated constants with "connectivity_" prefix matching iOS values: - Property key: "test" instead of "type" - WP.com value: "wpCom" instead of "wp_com" - Orders value: "orders" instead of "jetpack_tunnel" - Internet/site/products values already matched
51dfa57 to
b1cc403
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## hack-week/improve-troubleshooting-screen #15584 +/- ##
==============================================================================
+ Coverage 39.62% 39.65% +0.02%
- Complexity 11333 11342 +9
==============================================================================
Files 2260 2261 +1
Lines 130588 130644 +56
Branches 18301 18311 +10
==============================================================================
+ Hits 51750 51803 +53
+ Misses 73542 73538 -4
- Partials 5296 5303 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Adds a "Fetching products in your store" connectivity check as the 5th and final test in the Troubleshoot Connection screen (Milestone 2). Also aligns all connectivity tool analytics event values with iOS for cross-platform consistency.
Test Steps
Happy path:
Products failure:
adb shell am broadcast -p com.woocommerce.android.dev -a com.woocommerce.android.apifaker.SET_STATUS --ez enabled false adb shell am broadcast -p com.woocommerce.android.dev -a com.woocommerce.android.apifaker.CLEAR_ENDPOINTSOrders failure (products check should not run):
adb shell am broadcast -p com.woocommerce.android.dev -a com.woocommerce.android.apifaker.SET_STATUS --ez enabled false adb shell am broadcast -p com.woocommerce.android.dev -a com.woocommerce.android.apifaker.CLEAR_ENDPOINTSImages/gif
verification_recording.mov
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.