[WOOMOB-2450][POS Refunds: M3] Add refund details dialog to POS order details by samiuelson · Pull Request #15502 · woocommerce/woocommerce-android

samiuelson · 2026-03-09T17:47:55Z

Description

When a refund row is tapped in the POS order details Totals section, a dialog now shows the refund's breakdown: refunded items with images, quantities and prices, items subtotal, tax, refund total, and payment method.

Changes:

Expand refund rows in Totals to show date, reason, and a "View details" link
Add RefundRow data class and RefundDetails dialog state
Enrich RefundInfo with per-refund metadata (label, date, reason, full Refund object)
Create WooPosRefundDetailsDialog composable using WooPosDialogWrapper
Wire dialog through ViewModel with proper state management
Refunds are enumerated from oldest to newest

Test Steps

Open a POS order that has one or more refunds
Scroll to the Totals section — verify each refund row shows: "Refund #N" with amount, date, optional reason, and "View details" link
Tap anywhere on a refund row — verify the refund details dialog opens
In the dialog, verify: title matches "Refund #N", refunded items are listed with images/names/qty/prices, items subtotal, tax, refund total, and payment method are shown
Tap the X button or outside the dialog — verify it dismisses

Images/gif

I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

Replace the simple List<String> refund amounts in TotalsBreakdown with a structured RefundRow (label, amount, date, reason). Update RefundInfo to carry RefundRowData preserving the full Refund object for dialog use. Refunds are sorted oldest-first before numbering. Add RefundDetails variant to DialogState and new string resources.

Add ViewRefundDetailsClicked UI event and handle it in the ViewModel by building dialog state from the stored RefundRowData. Add buildLineItemsForSingleRefund to the mapper so the dialog can show per-refund item breakdown. Store current refund rows alongside the selected order for quick dialog construction.

Introduce WooPosRefundDetailsDialog composable showing refunded items, subtotal, tax, and total when "View details" is tapped. Update refund rows in the totals section to display date, reason, and a clickable "View details" link. Wire the dialog into WooPosOrdersScreen.

dangermattic · 2026-03-09T17:49:06Z

	1 Warning
⚠️	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

wpmobilebot · 2026-03-09T18:04:23Z

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Build Number	`734`
	Version	`24.3-rc-3`
	Application ID	`com.woocommerce.android.prealpha`
	Commit	`51b888c`
	Installation URL	63r0v1apbvap8

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

codecov-commenter · 2026-03-09T18:42:40Z

Codecov Report

❌ Patch coverage is 33.43653% with 215 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.53%. Comparing base (9e92207) to head (51b888c).
⚠️ Report is 16 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...orders/details/refund/WooPosRefundDetailsDialog.kt	0.00%	125 Missing ⚠️
...oid/ui/woopos/orders/details/WooPosOrderDetails.kt	0.00%	65 Missing ⚠️
.../android/ui/woopos/orders/WooPosOrdersViewModel.kt	76.47%	6 Missing and 10 partials ⚠️
...s/orders/details/refund/WooPosRefundInfoBuilder.kt	83.78%	5 Missing and 1 partial ⚠️
.../woopos/orders/details/WooPosOrderDetailsMapper.kt	70.00%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##              trunk   #15502      +/-   ##
============================================
- Coverage     39.54%   39.53%   -0.02%     
- Complexity    11237    11248      +11     
============================================
  Files          2251     2252       +1     
  Lines        129763   130058     +295     
  Branches      18170    18208      +38     
============================================
+ Hits          51318    51415      +97     
- Misses        73208    73395     +187     
- Partials       5237     5248      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Center the title, make items list scrollable, update divider thickness, and fix TotalRowLine to use consistent text styling.

Handle singular/plural forms correctly (e.g. "1 item" vs "2 items") by switching to getQuantityString.

…ls-of-historical-refunds

Copilot

Pull request overview

This PR adds a refund details dialog to the POS order details screen, allowing users to tap on a refund row to view a breakdown that includes refunded items (with images, quantities, and prices), items subtotal, tax, refund total, and payment method. It is part of the M3 milestone for POS Refunds (WOOMOB-2450).

Changes:

Enriched RefundInfo/RefundRowData with per-refund metadata (label, date, reason, full Refund object) and updated TotalsBreakdown.refunds from List<String> to List<RefundRow>
Added WooPosRefundDetailsDialog composable and wired the new RefundDetails dialog state through ViewModel events (ViewRefundDetailsClicked) and screen-level handling
Added buildLineItemsForSingleRefund to WooPosOrderDetailsMapper and new state management fields (currentRefundRows, currentOrderForRefunds) in the ViewModel to support showing per-refund line items

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
`WooPosRefundInfoBuilder.kt`	Builds `RefundRowData` per refund with label, date, reason, and amount; changed error handling
`WooPosOrderDetailsMapper.kt`	Added `buildLineItemsForSingleRefund` for building line items for a single refund
`WooPosOrdersState.kt`	Added `RefundRow` data class and `RefundDetails` dialog state
`WooPosOrdersUIEvent.kt`	Added `ViewRefundDetailsClicked` UI event
`WooPosOrdersViewModel.kt`	Added state management for refund details dialog; new `currentRefundRows`/`currentOrderForRefunds` fields
`WooPosOrderDetails.kt`	Refund rows now show label, date, reason, and a "View details" link; whole row is tappable
`WooPosRefundDetailsDialog.kt`	New dialog composable displaying refund item breakdown
`WooPosOrdersScreen.kt`	Wired new `RefundDetails` dialog state into screen rendering
`strings.xml`	Added string resources for refund label, tax, total, subtotal plurals, and dialog background
`WooPosOrderDetailsMapperTest.kt`	Updated mock for renamed `RefundInfo` constructor parameter
`WooPosOrdersViewModelTest.kt`	Added `formatPrice` dependency and updated refund row assertions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/orders/WooPosOrdersViewModel.kt

...in/kotlin/com/woocommerce/android/ui/woopos/orders/details/refund/WooPosRefundInfoBuilder.kt

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/orders/WooPosOrdersViewModel.kt

...src/main/kotlin/com/woocommerce/android/ui/woopos/orders/details/WooPosOrderDetailsMapper.kt

malinajirka

Thanks @samiuelson! I haven't found anything critical, but a couple things worth considering.

The bottom padding of the last item in the list is always smaller - notice the space between the product image and divider below it is different between the first and second items.

It is very easy to miss that the content is scrollable - I'd consider adding a shadow on top of the Totals section when there is a scroll. We use the same pattern for example in the cart. (P.S. I noticed the same issue in the process refund dialog)

The centered title feels a bit off - the designs show it centered to the left.

malinajirka · 2026-03-11T06:55:27Z

...in/kotlin/com/woocommerce/android/ui/woopos/orders/details/refund/WooPosRefundInfoBuilder.kt

-                        emptyList()
-                    }
-                RefundInfo(amounts, BigDecimal.ZERO)
+                RefundInfo(emptyList(), BigDecimal.ZERO)


❓ Seems like previously we showed an error when we failed to load refunds, but now we ignore the error. Is this an intentional change?

Good catch — this was unintentional. Restored showing the inline error in a86b94d

malinajirka · 2026-03-11T07:02:19Z

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/orders/WooPosOrdersViewModel.kt

    private var loadingMoreOrdersJob: Job? = null
    private var sideLoadActionsJob: Job? = null

+    private var currentRefundRows: List<RefundRowData> = emptyList()


📓 I technically don't see any bug with this approach, but considering we have one VM for everything, with no actual encapsulation (just to be clear, this wasn't introduced in this or previous PR, but over time), I'm worried having multiple independent states that can easily get out of sync is quite risky. Could we somehow make this state dependent on the currently selected order to ensure we don't display refunds for a different order with future code changes? (not necessarily in this PR, but as an maintainability improvement)

Agreed, having those as independent var fields was fragile. Consolidated currentRefundRows and currentOrderForRefunds into a single CachedRefundData(orderId, rows, order) data class so they can't drift apart → 9162519

malinajirka · 2026-03-11T07:09:42Z

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/orders/WooPosOrdersViewModel.kt

+            val refundTotal = formatPrice(rowData.refund.amount, order.currency)
+
+            val updatedState = _state.value as? WooPosOrdersState.Content ?: return@launch
+            _state.value = updatedState.copy(


💡 I'd consider adding a check if still the same order is selected - the coroutine might take a while to start and complete.

Good idea — added here → 2ed4282

Add refundLoadError field to RefundInfo and TotalsBreakdown so the UI can display an inline error message when fetching refunds fails, instead of silently returning empty data.

Replace independent currentRefundRows and currentOrderForRefunds fields with a single CachedRefundData data class that ties the orderId, refund rows, and order together to prevent them from getting out of sync.

Verify the selected order still matches the cached refund data before showing the refund details dialog, preventing stale data from appearing if the user navigated to a different order while the coroutine ran.

…hadow and spacing

samiuelson · 2026-03-11T17:35:04Z

Thanks for review, Jirka!

The bottom padding of the last item in the list is always smaller - notice the space between the product image and divider below it is different between the first and second items.

It is very easy to miss that the content is scrollable - I'd consider adding a shadow on top of the Totals section when there is a scroll. We use the same pattern for example in the cart. (P.S. I noticed the same issue in the process refund dialog)

Both 1. and 2. were addressed in c8119fa

The centered title feels a bit off - the designs show it centered to the left.

This is intentional divergence from figma specs, suggested by @kidinov in past, to keep refund-specific dialogs consistent with other dialogs in POS.

…ls-of-historical-refunds

samiuelson added 3 commits March 9, 2026 18:31

samiuelson added type: enhancement A request for an enhancement. feature: point of sale POS project labels Mar 9, 2026

samiuelson changed the title ~~[WOOMOB-2450] Add refund details dialog to POS order details~~ [WOOMOB-2450][POS Refunds: M3] Add refund details dialog to POS order details Mar 10, 2026

samiuelson added 2 commits March 10, 2026 12:59

Polish refund details dialog layout and styling

035cd80

Center the title, make items list scrollable, update divider thickness, and fix TotalRowLine to use consistent text styling.

Use quantity strings for refund items subtotal label

1f992cc

Handle singular/plural forms correctly (e.g. "1 item" vs "2 items") by switching to getQuantityString.

samiuelson added this to the 24.4 milestone Mar 10, 2026

samiuelson removed the type: enhancement A request for an enhancement. label Mar 10, 2026

samiuelson requested a review from Copilot March 10, 2026 12:02

Copilot started reviewing on behalf of samiuelson March 10, 2026 12:03 View session

samiuelson marked this pull request as ready for review March 10, 2026 12:04

Merge branch 'trunk' into woomob-2450-woo-posrefuds-milestone-3-detai…

bbeaad6

…ls-of-historical-refunds

Copilot AI reviewed Mar 10, 2026

View reviewed changes

samiuelson added 4 commits March 10, 2026 13:52

Remove unused variable and fix fully-qualified BigDecimal reference

977af92

Extract shared buildLineItemsFromRefunds helper to reduce duplication

e9fed24

Add tests for refund details dialog open, dismiss, and invalid index

0615f4e

Satisfy detekt's complaints

96e62ae

samiuelson requested a review from malinajirka March 10, 2026 13:31

malinajirka self-assigned this Mar 11, 2026

malinajirka approved these changes Mar 11, 2026

View reviewed changes

samiuelson added 4 commits March 11, 2026 15:46

Restore error indicator when refund loading fails

a86b94d

Add refundLoadError field to RefundInfo and TotalsBreakdown so the UI can display an inline error message when fetching refunds fails, instead of silently returning empty data.

Consolidate cached refund data into a single CachedRefundData object

9162519

Replace independent currentRefundRows and currentOrderForRefunds fields with a single CachedRefundData data class that ties the orderId, refund rows, and order together to prevent them from getting out of sync.

Add stale order guard in onViewRefundDetailsClicked

2ed4282

Verify the selected order still matches the cached refund data before showing the refund details dialog, preventing stale data from appearing if the user navigated to a different order while the coroutine ran.

Use WooPosLazyColumn in refund details dialog for consistent scroll s…

c8119fa

…hadow and spacing

Merge branch 'trunk' into woomob-2450-woo-posrefuds-milestone-3-detai…

51b888c

…ls-of-historical-refunds

samiuelson enabled auto-merge March 11, 2026 17:35

samiuelson merged commit a284699 into trunk Mar 11, 2026
16 checks passed

samiuelson deleted the woomob-2450-woo-posrefuds-milestone-3-details-of-historical-refunds branch March 11, 2026 18:08

Conversation

samiuelson commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Test Steps

Images/gif

Uh oh!

dangermattic commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

malinajirka left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

malinajirka Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

samiuelson Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

malinajirka Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

samiuelson Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

malinajirka Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

samiuelson Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

samiuelson commented Mar 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

samiuelson commented Mar 9, 2026 •

edited

Loading

dangermattic commented Mar 9, 2026 •

edited

Loading

wpmobilebot commented Mar 9, 2026 •

edited

Loading

codecov-commenter commented Mar 9, 2026 •

edited

Loading

malinajirka left a comment •

edited

Loading