[WOOMOB-2421] Fix product detail webview URL path#15499
[WOOMOB-2421] Fix product detail webview URL path#15499hichamboushaba merged 2 commits intorelease/24.3from
Conversation
|
|
|
@hichamboushaba , I've already opened an issue for this (#15491: I previously added |
|
@irfano thanks for the ping, sorry I didn't see your PR. Regarding the rename, I don't have a strong opinion, but just explaining my rationale for using the generic names in the first place, I wanted to have this as reusable and easy to extend, so if we want to use the same pattern for another product type, we can do it quickly by just updating the logic in two areas: in As I said, it's not a strong opinion, so feel free to close this PR if my point doesn't make sense to you. |
|
FYI. I believe that the WOOMOB-2421 is about supporting the I'm not fully sure how to create such product though 🤔 |
|
@hichamboushaba , I closed my PR after your comment. Let's proceed with this one, and don't forget to target the release branch. |
Add missing admin.php segment and use the correct /woocommerce/services/edit/ path for the next-admin URL.
81cef4e to
f353910
Compare
Project manifest changes for WooCommerceThe following changes in the --- ./build/reports/diff_manifest/WooCommerce/vanillaRelease/base_manifest.txt 2026-03-09 14:24:22.810871589 +0000
+++ ./build/reports/diff_manifest/WooCommerce/vanillaRelease/head_manifest.txt 2026-03-09 14:24:29.240849562 +0000
@@ -1,8 +1,8 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.woocommerce.android"
- android:versionCode="732"
- android:versionName="24.3-rc-1" >
+ android:versionCode="733"
+ android:versionName="24.3-rc-2" >
<uses-sdk
android:minSdkVersion="26"Go to https://buildkite.com/automattic/woocommerce-android/builds/36394/canvas?sid=019cd2f7-612b-4e25-a05b-446df57a612d, click on the |
Project manifest changes for WooCommerce-WearThe following changes in the --- ./build/reports/diff_manifest/WooCommerce-Wear/vanillaRelease/base_manifest.txt 2026-03-09 14:24:39.250815200 +0000
+++ ./build/reports/diff_manifest/WooCommerce-Wear/vanillaRelease/head_manifest.txt 2026-03-09 14:24:44.310797820 +0000
@@ -1,8 +1,8 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.woocommerce.android"
- android:versionCode="50732"
- android:versionName="24.3-rc-1w" >
+ android:versionCode="50733"
+ android:versionName="24.3-rc-2w" >
<uses-sdk
android:minSdkVersion="26"Go to https://buildkite.com/automattic/woocommerce-android/builds/36394/canvas?sid=019cd2f7-612b-4e25-a05b-446df57a612d, click on the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/24.3 #15499 +/- ##
===============================================
Coverage 39.53% 39.53%
- Complexity 11210 11211 +1
===============================================
Files 2250 2250
Lines 129326 129326
Branches 18094 18094
===============================================
Hits 51129 51129
- Misses 72986 72987 +1
+ Partials 5211 5210 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|

Fixes WOOMOB-2421
Description
Fix the product detail webview URL by adding the missing
admin.phpsegment and using the correct/woocommerce/services/edit/path instead of/woocommerce/products/edit/.Test Steps
Images/gif
N/A
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.