Skip to content

[WOOMOB-2421] Fix product detail webview URL path#15499

Merged
hichamboushaba merged 2 commits intorelease/24.3from
issue/WOOMOB-2421-fix-product-webview-url
Mar 9, 2026
Merged

[WOOMOB-2421] Fix product detail webview URL path#15499
hichamboushaba merged 2 commits intorelease/24.3from
issue/WOOMOB-2421-fix-product-webview-url

Conversation

@hichamboushaba
Copy link
Copy Markdown
Member

@hichamboushaba hichamboushaba commented Mar 9, 2026

Fixes WOOMOB-2421

Description

Fix the product detail webview URL by adding the missing admin.php segment and using the correct /woocommerce/services/edit/ path instead of /woocommerce/products/edit/.

Test Steps

  1. Use a CIAB site.
  2. Open a bookable product in the app
  3. Verify the webview loads correctly with the proper admin URL
  4. Confirm the product edit page renders as expected

Images/gif

N/A

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@wpmobilebot
Copy link
Copy Markdown
Collaborator

wpmobilebot commented Mar 9, 2026

App Icon📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App NameWooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Build Number733
Version24.3-rc-2
Application IDcom.woocommerce.android.prealpha
Commitf353910
Installation URL5d4a6usnis700
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@irfano
Copy link
Copy Markdown
Contributor

irfano commented Mar 9, 2026

@hichamboushaba , I've already opened an issue for this (#15491: I previously added services and now I've also added admin.php to the link). I also renamed the ProductDetailWebViewBookableServiceDetailWebView. If that renaming makes sense to you, let's proceed with my PR.

@hichamboushaba
Copy link
Copy Markdown
Member Author

hichamboushaba commented Mar 9, 2026

@irfano thanks for the ping, sorry I didn't see your PR.

Regarding the rename, I don't have a strong opinion, but just explaining my rationale for using the generic names in the first place, I wanted to have this as reusable and easy to extend, so if we want to use the same pattern for another product type, we can do it quickly by just updating the logic in two areas: in openInWebViewIfNeeded and in the ProductDetailWebViewModel to construct the correct URL.

As I said, it's not a strong opinion, so feel free to close this PR if my point doesn't make sense to you.

@AdamGrzybkowski
Copy link
Copy Markdown
Contributor

FYI. I believe that the WOOMOB-2421 is about supporting the bookable type together with the bookable-service here. From the walkthrough, you could see that the bookable type would be opened in the app's native view, but it doesn't support it fully.

I'm not fully sure how to create such product though 🤔

@irfano
Copy link
Copy Markdown
Contributor

irfano commented Mar 9, 2026

@hichamboushaba , I closed my PR after your comment. Let's proceed with this one, and don't forget to target the release branch.

Add missing admin.php segment and use the correct /woocommerce/services/edit/ path for the next-admin URL.
@hichamboushaba hichamboushaba force-pushed the issue/WOOMOB-2421-fix-product-webview-url branch from 81cef4e to f353910 Compare March 9, 2026 14:19
@hichamboushaba hichamboushaba changed the base branch from trunk to release/24.3 March 9, 2026 14:24
@wpmobilebot
Copy link
Copy Markdown
Collaborator

Project manifest changes for WooCommerce

The following changes in the WooCommerce's merged AndroidManifest.xml file were detected (build variant: vanillaRelease):

--- ./build/reports/diff_manifest/WooCommerce/vanillaRelease/base_manifest.txt	2026-03-09 14:24:22.810871589 +0000
+++ ./build/reports/diff_manifest/WooCommerce/vanillaRelease/head_manifest.txt	2026-03-09 14:24:29.240849562 +0000
@@ -1,8 +1,8 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
     package="com.woocommerce.android"
-    android:versionCode="732"
-    android:versionName="24.3-rc-1" >
+    android:versionCode="733"
+    android:versionName="24.3-rc-2" >
 
     <uses-sdk
         android:minSdkVersion="26"

Go to https://buildkite.com/automattic/woocommerce-android/builds/36394/canvas?sid=019cd2f7-612b-4e25-a05b-446df57a612d, click on the Artifacts tab and audit the files.

@wpmobilebot
Copy link
Copy Markdown
Collaborator

Project manifest changes for WooCommerce-Wear

The following changes in the WooCommerce-Wear's merged AndroidManifest.xml file were detected (build variant: vanillaRelease):

--- ./build/reports/diff_manifest/WooCommerce-Wear/vanillaRelease/base_manifest.txt	2026-03-09 14:24:39.250815200 +0000
+++ ./build/reports/diff_manifest/WooCommerce-Wear/vanillaRelease/head_manifest.txt	2026-03-09 14:24:44.310797820 +0000
@@ -1,8 +1,8 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
     package="com.woocommerce.android"
-    android:versionCode="50732"
-    android:versionName="24.3-rc-1w" >
+    android:versionCode="50733"
+    android:versionName="24.3-rc-2w" >
 
     <uses-sdk
         android:minSdkVersion="26"

Go to https://buildkite.com/automattic/woocommerce-android/builds/36394/canvas?sid=019cd2f7-612b-4e25-a05b-446df57a612d, click on the Artifacts tab and audit the files.

@AdamGrzybkowski AdamGrzybkowski self-assigned this Mar 9, 2026
Copy link
Copy Markdown
Contributor

@AdamGrzybkowski AdamGrzybkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.53%. Comparing base (f16b530) to head (f353910).

Additional details and impacted files
@@               Coverage Diff               @@
##             release/24.3   #15499   +/-   ##
===============================================
  Coverage           39.53%   39.53%           
- Complexity          11210    11211    +1     
===============================================
  Files                2250     2250           
  Lines              129326   129326           
  Branches            18094    18094           
===============================================
  Hits                51129    51129           
- Misses              72986    72987    +1     
+ Partials             5211     5210    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hichamboushaba hichamboushaba modified the milestones: 24.4, 24.3 ❄️ Mar 9, 2026
@hichamboushaba hichamboushaba merged commit 1fc8056 into release/24.3 Mar 9, 2026
17 checks passed
@hichamboushaba hichamboushaba deleted the issue/WOOMOB-2421-fix-product-webview-url branch March 9, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants