Skip to content

[WOOMOB-2413] Hide push notifications benefit behind flag #15498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hichamboushaba merged 1 commit into from
Mar 9, 2026
Merged

[WOOMOB-2413] Hide push notifications benefit behind flag #15498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions ...erce/src/main/kotlin/com/woocommerce/android/ui/jetpack/benefits/JetpackBenefitsScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,15 +83,17 @@ fun JetpackBenefitsScreen(
)
Spacer(modifier = Modifier.height(dimensionResource(id = R.dimen.major_200)))

// Push notifications
BenefitEntry(
icon = R.drawable.ic_alarm_bell_ring,
title = R.string.jetpack_benefits_modal_push_notifications_title,
subtitle = R.string.jetpack_benefits_modal_push_notifications_subtitle,
modifier = Modifier.padding(horizontal = dimensionResource(id = R.dimen.major_100))
)
if (viewState.isPushNotificationsBenefitVisible) {
// Push notifications
BenefitEntry(
icon = R.drawable.ic_alarm_bell_ring,
title = R.string.jetpack_benefits_modal_push_notifications_title,
subtitle = R.string.jetpack_benefits_modal_push_notifications_subtitle,
modifier = Modifier.padding(horizontal = dimensionResource(id = R.dimen.major_100))
)

Spacer(modifier = Modifier.height(dimensionResource(id = R.dimen.major_100)))
Spacer(modifier = Modifier.height(dimensionResource(id = R.dimen.major_100)))
}

// Analytics
BenefitEntry(
Expand Down Expand Up @@ -182,6 +184,7 @@ private fun JetpackBenefitsScreenPreview() {
viewState = JetpackBenefitsViewModel.ViewState(
isUsingJetpackCP = false,
isLoadingDialogShown = false,
isPushNotificationsBenefitVisible = true,
)
)
}
Expand All @@ -195,6 +198,7 @@ private fun JetpackBenefitsScreenWithoutNativeInstallPreview() {
viewState = JetpackBenefitsViewModel.ViewState(
isUsingJetpackCP = false,
isLoadingDialogShown = false,
isPushNotificationsBenefitVisible = true,
)
)
}
Expand Down
3 changes: 3 additions & 0 deletions ...e/src/main/kotlin/com/woocommerce/android/ui/jetpack/benefits/JetpackBenefitsViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import com.woocommerce.android.tools.SiteConnectionType
import com.woocommerce.android.ui.common.UserEligibilityFetcher
import com.woocommerce.android.ui.jetpack.FetchJetpackStatus
import com.woocommerce.android.ui.jetpack.FetchJetpackStatus.JetpackStatusFetchResponse
import com.woocommerce.android.util.FeatureFlag
import com.woocommerce.android.viewmodel.MultiLiveEvent.Event
import com.woocommerce.android.viewmodel.MultiLiveEvent.Event.Exit
import com.woocommerce.android.viewmodel.MultiLiveEvent.Event.ShowSnackbar
Expand Down Expand Up @@ -47,6 +48,7 @@ class JetpackBenefitsViewModel @Inject constructor(
ViewState(
isUsingJetpackCP = selectedSite.connectionType == SiteConnectionType.JetpackConnectionPackage,
isLoadingDialogShown = false,
isPushNotificationsBenefitVisible = !FeatureFlag.WOO_PUSH_NOTIFICATIONS_SYSTEM_M2.isEnabled(),
)
)
val viewState = _viewState.asLiveData()
Expand Down Expand Up @@ -184,6 +186,7 @@ class JetpackBenefitsViewModel @Inject constructor(
data class ViewState(
val isUsingJetpackCP: Boolean,
val isLoadingDialogShown: Boolean,
val isPushNotificationsBenefitVisible: Boolean,
)

object StartJetpackActivationForJetpackCP : Event()
Expand Down