Conversation
Collaborator
|
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## trunk #15484 +/- ##
============================================
- Coverage 39.55% 39.55% -0.01%
+ Complexity 11235 11233 -2
============================================
Files 2252 2251 -1
Lines 129662 129723 +61
Branches 18165 18163 -2
============================================
+ Hits 51290 51306 +16
- Misses 73134 73180 +46
+ Partials 5238 5237 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DbSearchResult now carries searchTimeMillis and searchMethod through SearchProductsResult.Local. FtsSyncResult returns duration and count from FTS sync operations for downstream tracking.
Add SearchResultsFetched, FtsIndexBuilt, and SearchResultTapped events. Track FTS index build duration and product count in both full and incremental sync paths.
Track search performance (time, count, method) when local search returns results. Track position and type when a search result is tapped.
FTS search is now the only search path for POS products. Removed IsPosProductsFtsEnabled class, the LIKE search fallback, and all related feature flag guards and tests.
7afedd2 to
2f3a9ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Fixes WOOMOB-2073
Adds analytics tracking for POS Full-Text Search to measure search performance, ranking quality, and indexing overhead. This PR also includes the full FTS stack from parent branches (search implementation with relevance ranking, UI wiring with variation support) and removes the
POS_PRODUCTS_FTSfeature flag to make FTS always-on.Analytics events added (as agreed in the P2 post):
search_results_fetched— tracks local FTS search latency, result count, and search methodfts_index_built— tracks FTS index build duration and size during sync (Android only)pos_search_result_tapped— tracks result position and type (product/variation) for search quality measurementOther changes:
FeatureFlag.POS_PRODUCTS_FTSandIsPosProductsFtsEnabled— FTS is now the only search pathTest Steps
search_results_fetchedwithsearch_method: ftspos_search_result_tappedwith correctresult_positionfts_index_builtwithsync_type: fullImages/gif
N/A
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.