-
Notifications
You must be signed in to change notification settings - Fork 142
[WOOMOB-2061] Add analytics tracking for file-based catalog sync #15288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
8ff12c6
Add LOCAL_CATALOG_FILE to SyncStrategy enum
malinajirka 0cf6419
Add file-based sync properties to PosLocalCatalogSyncResult
malinajirka 7ed8ba8
Add poll attempts persistence to WooPosPreferencesRepository
malinajirka dd5c0a1
Add generation duration calculation to WooPosSyncTimestampManager
malinajirka d6c1bac
Track poll attempts and generation duration in WooPosFileBasedSyncAction
malinajirka 156eb30
Add file-based sync properties to analytics events
malinajirka a8b90d7
Pass file-based sync analytics data to tracking events
malinajirka d564a77
Fix SyncStrategy checks to include LOCAL_CATALOG_FILE
malinajirka 585d1ff
Fix detekt
malinajirka 286cae3
Merge branch 'trunk' into woomob/add-file-based-catalog-analytics
malinajirka fb649df
Remove analytics plan for file-based local catalog sync documentation
malinajirka 43101d9
Replace `getFile...PollAttempts` with `getAndClear...PollAttempts`
malinajirka 1521985
Remove unused `clearFileBasedSyncPollAttempts` function from WooPosPr…
malinajirka c617c1a
Add unit tests for poll attempts, generation duration, and timeout ha…
malinajirka 8c261aa
Refactor poll attempt tracking in `WooPosFileBasedSyncAction`
malinajirka 1e42304
Merge branch 'trunk' into woomob/add-file-based-catalog-analytics
malinajirka 3da68ee
Refactor WooPosFileBasedSyncAction failure handling and improve track…
malinajirka cb6851f
Refactor error tracking in WooPosLocalCatalogSyncRepository to use re…
malinajirka bd140cd
Add tests to validate poll attempt persistence and failure details in…
malinajirka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getAndClearFileBasedSyncPollAttempts()clears the persisted counter at the start of a run, but most non-timeout failure paths (e.g., consecutive network failures, download/parse/store failures, missing URL) return without re-persisting the updated count. This can drop previously accumulated attempts and defeats the “accumulated across app restarts” behavior. Consider reading without clearing, incrementing as you poll, and only clearing on successful completion (or re-saving the latest total on any early exit/failure).