Disable API Pull mode for all users#3273
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #3273 +/- ##
===========================================
- Coverage 66.5% 66.4% -0.1%
- Complexity 5095 5113 +18
===========================================
Files 507 509 +2
Lines 20312 20349 +37
===========================================
+ Hits 13504 13511 +7
- Misses 6808 6838 +30
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
jjgrainger
requested changes
Feb 26, 2026
Collaborator
jjgrainger
left a comment
There was a problem hiding this comment.
Thanks @jamesmorrison looking good, just some feedback to review.
jjgrainger
requested changes
Mar 2, 2026
Collaborator
jjgrainger
left a comment
There was a problem hiding this comment.
Thanks @jamesmorrison looking good, just some minor feedback/cleanup before the release tomorrow.
jjgrainger
approved these changes
Mar 3, 2026
Collaborator
QA ✅
|
joemcgill
approved these changes
Mar 3, 2026
| foreach ( $sync_mode as $key => $entry ) { | ||
| if ( is_array( $entry ) && array_key_exists( 'pull', $entry ) ) { | ||
| $sync_mode[ $key ]['pull'] = false; | ||
| if ( true === $sync_mode[ $key ]['pull'] ) { |
Collaborator
There was a problem hiding this comment.
👍🏻 This update looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Closes https://linear.app/a8c/issue/GOOWOO-483/disable-api-pull-mode-for-all-users
Screenshots:
N/A
Detailed test instructions:
1. Prepare the DB (pull enabled)
Set the sync mode option so some datatypes have pull enabled (use direct DB update so filters don’t overwrite it):
wp db query "UPDATE wp_options SET option_value = 'a:4:{s:8:\"products\";a:2:{s:4:\"push\";b:1;s:4:\"pull\";b:1;}s:7:\"coupons\";a:2:{s:4:\"push\";b:1;s:4:\"pull\";b:0;}s:8:\"shipping\";a:2:{s:4:\"push\";b:1;s:4:\"pull\";b:1;}s:8:\"settings\";a:2:{s:4:\"push\";b:1;s:4:\"pull\";b:0;}}' WHERE option_name = 'gla_api_pull_sync_mode';"(Replace
wp_optionswith your table prefix if different, e.g.wp_2_options.)Verify:
wp db query "SELECT option_value FROM wp_options WHERE option_name = 'gla_api_pull_sync_mode';"You should see
pullwithb:1for products and shipping.2. Trigger the migration
Set the stored DB version to 3.5.2 so the 3.5.3 migration runs on next admin load:
wp option update gla_db_version 3.5.2(Or via SQL:
wp db query "UPDATE wp_options SET option_value = '3.5.2' WHERE option_name = 'gla_db_version';")3. Run the migration
Load the Google for WooCommerce admin page:
https://yoursite.test/wp-admin/admin.php?page=wc-admin&path=%2Fgoogle%2Fdashboard4. Set the plugin version to
3.5.3google-listings-and-ads.phpset the version to 3.5.3 on lines 6 (plugin header) and 36 (plugin constant)5. Verify migration and version
wp option get gla_db_version→ expected:3.5.3. If you still see3.5.2, clear object cache and reload the admin page once.wp db query "SELECT option_value FROM wp_options WHERE option_name = 'gla_api_pull_sync_mode';"→ expected: allpullareb:0(e.g....s:4:\"pull\";b:0;...for each datatype).wp option get gla_api_pull_sync_mode --format=json→ expected: every datatype has"pull": false, e.g.{"products":{"pull":false,"push":true},"coupons":{"pull":false,"push":true},"shipping":{"pull":false,"push":true},"settings":{"pull":false,"push":true}}.6. Revert the plugin version to
3.5.2google-listings-and-ads.phpset the version to 3.5.2 on lines 6 (plugin header) and 36 (plugin constant) - should show no git changes after completing this step.Additional details:
Changelog entry