[GOOWOO-474] Performance: Avoid uncached Ads API request in NotificationManager#3263
Open
jamesmorrison wants to merge 2 commits intodevelopfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3263 +/- ##
===========================================
- Coverage 66.8% 66.6% -0.2%
- Complexity 5095 5097 +2
===========================================
Files 867 507 -360
Lines 26180 20326 -5854
Branches 1466 0 -1466
===========================================
- Hits 17479 13528 -3951
+ Misses 8528 6798 -1730
+ Partials 173 0 -173
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
jjgrainger
requested changes
Feb 19, 2026
Collaborator
jjgrainger
left a comment
There was a problem hiding this comment.
Thanks @jamesmorrison looks good, left some minor feedback
jjgrainger
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Closes https://linear.app/a8c/issue/GOOWOO-474/performance-avoid-uncached-ads-api-request-in-notificationmanager
Screenshots:
Before clearing transient cache:

After clearing transient cache (i.e. the data is looked up and stored):

Detailed test instructions:
wp transient get gla_ads_highest_spend_campaign- the transient should not exist at this point so expect the output to be:Warning: Transient with key "gla_ads_highest_spend_campaign" is not set.wp transient get gla_ads_highest_spend_campaignYou should see array data set now, for example:Additional details: