Add deduplication logic for selected items in CompareFilter component#3253
Open
AlejandroPerezMartin wants to merge 4 commits intodevelopfrom
Open
Add deduplication logic for selected items in CompareFilter component#3253AlejandroPerezMartin wants to merge 4 commits intodevelopfrom
AlejandroPerezMartin wants to merge 4 commits intodevelopfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3253 +/- ##
============================================
+ Coverage 66.8% 67.7% +1.0%
============================================
Files 867 360 -507
Lines 26180 5866 -20314
Branches 1466 1466
============================================
- Hits 17479 3973 -13506
+ Misses 8528 1720 -6808
Partials 173 173
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
asvinb
requested changes
Feb 11, 2026
asvinb
approved these changes
Feb 11, 2026
Collaborator
|
Thanks @AlejandroPerezMartin . Changes LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
The Programs Comparison filter allows duplicate program selections, leading to console errors when trying to compare as well as duplicates in the selected filters. This PR filters the response from the Woocommerce Search component and removes duplicated items.
Closes https://linear.app/a8c/issue/GOOWOO-314/duplicate-programs-can-be-selected-in-the-comparison-filter-causing
Replace this with a good description of your changes & reasoning.
Screenshots:
Detailed test instructions:
Additional details:
Changelog entry