20260623-WC_16BIT_CPU-WC_ATOMIC_INT_ARG#10763
Merged
philljj merged 1 commit intoJun 23, 2026
Merged
Conversation
…ortability, use target native int for WC_ATOMIC_INT_ARG, add user overrideability, and adjust WC_INIT_STATE_COUNT_BITS to depend on sizeof(WC_ATOMIC_UINT_ARG). add a wc_static_assert to sanity-check WC_INIT_STATE_STATE_BITS, and use CHAR_BIT opportunistically in the other wc_static_assert to sanity check that CHAR_BIT is at least 8.
douzzer
requested review from
dgarske,
philljj,
wolfSSL-Bot and
wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10763
Scan targets checked: wolfcrypt-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src
No new issues found in the changed files. ✅
Contributor
Author
|
retest this please |
dgarske
approved these changes
Jun 23, 2026
philljj
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wolfssl/wolfcrypt/wc_port.handwolfcrypt/src/wc_port.c: for 16 bit portability, use target nativeintforWC_ATOMIC_INT_ARG, add user overrideability, and adjustWC_INIT_STATE_COUNT_BITSto depend onsizeof(WC_ATOMIC_UINT_ARG). add awc_static_assertto sanity-checkWC_INIT_STATE_STATE_BITS, and useCHAR_BITopportunistically in the otherwc_static_assertto sanity check thatCHAR_BITis at least8.fixes ZD#22027
tested with