tinywl: Add xdg-shell server as a dependency.#182
tinywl: Add xdg-shell server as a dependency.#182Zeckmathederg wants to merge 2 commits intowlrfx:mainfrom
Conversation
|
Thanks for the PR! it looks good, but since upstream no longer contains those lines I think it's best to follow their path and remove them too. |
|
The server header will still be necessary, unless changed with wlroots-0.20.0. However, the client header shouldn't be necessary anymore, even with 0.19.x. So a simple replace with |
Because wayland-protocols now ships a client header for xdg-shell, it no longer needs to be generated. However, the server header must be generated since the server header is not provided.
|
I double checked with wlroots-0.20. Specifically, So for now, I would recommend merging anyway, but this should be changed when wlroots-0.20 compatibility comes in. |
Under some configurations when
-D examples=trueis passed tomeson, ninja will fail to build thetinywl/tinywl.p/tinywl.c.otarget becauseprotocols_server_header['xdg-shell']wasn't added as a source.tinywl/tinywl.p/tinywl.cincludesxdg-shell-protocol.hwhich is generated fromprotocols_server_header['xdg-shell'], but if parallelism is too high, or when using samurai, since the dependency information is incomplete, the protocol server header won't generate beforetinywl/tinywl.p/tinywl.c.ois attempted to be built, and will then proceed to fail.This commit/PR fixes the issue for all configurations.