Use the wlroots gles2 renderer instead of our own renderer#179
Draft
ErikReider wants to merge 4 commits intomainfrom
Draft
Use the wlroots gles2 renderer instead of our own renderer#179ErikReider wants to merge 4 commits intomainfrom
ErikReider wants to merge 4 commits intomainfrom
Conversation
Member
|
I'll review what we have so far, but what's pending? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces our renderer with the generic wlroots gles2 renderer while only keeping what we need.
This will allow us to add additional renderers in the future (like vulkan) without soft-forking the entire wlroots rendering logic.
There's one breaking change which is the addition of
scenefx_init()which replacesfx_renderer_create()To test with SwayFX, use this PR
We could go a step further and make the fx_renderer generic like the base wlr_renderer struct, creating a
fx_gles2_rendererstruct. This would "simplify" the process of adding a new renderer even further.