Closed
Conversation
Member
|
Could I see a screenshot of what it looks like after the PR is applied? Logic looks good but want to see it as well |
Member
Author
Member
Are you applying the blur to the border scene_buffer? I'm not really getting that's being shown here |
Member
Author
|
@ErikReider I'm applying blur to the scene rect's of the border's and titlebar, as seen here The top and bottom border in screenshots are made taller to accommodate the border radius, and then a clipping region is used to still display the content behind it. e.g. without the patch but also without blur it displays fine
|
Member
|
Just one comment, thanks! |
3cb4b67 to
c42748e
Compare
c42748e to
5204966
Compare
Member
Author
|
clipping in favor of #149 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Currently blur does not respect the clipping region
So when blur is enabled on an element, and a clipping region is applied, the clipping region is filled with blur.
My PR on swayfx is affected by this as shown by discord user ahf
Both the top and bottom parts shouldn't be covered by blur and simply show the contents of the main buffer, however the border is rendered after the content, and overlays it with the blur.
Adding this clipping code fixes it.