Skip to content

Feature/brush tool#1728

Open
kancheng wants to merge 21 commits intowkentaro:mainfrom
kancheng:feature/brush-tool
Open

Feature/brush tool#1728
kancheng wants to merge 21 commits intowkentaro:mainfrom
kancheng:feature/brush-tool

Conversation

@kancheng
Copy link
Contributor

@kancheng kancheng commented Jan 5, 2026

This PR focuses only on the brush drawing tool:

  • Add brush size control
  • Add a cancel/delete action for brush drawing
  • Fix a Qt6 crash caused by float arguments passed to QPainter.drawEllipse
  • Update brush button positions

No localization or unrelated changes are included.

@kancheng
Copy link
Contributor Author

kancheng commented Jan 5, 2026

demo details
螢幕快照 2026-01-06 07-05-15

@kancheng
Copy link
Contributor Author

kancheng commented Jan 6, 2026

如需詳細演示,請參閱:#1726

@kancheng kancheng force-pushed the feature/brush-tool branch from 2f3cb48 to ccd96b0 Compare January 7, 2026 21:57
@kancheng
Copy link
Contributor Author

kancheng commented Jan 7, 2026

@wkentaro

I wanted to briefly explain the current CI status. At the moment, the only failing check is:

ci / check (pull_request)

In this PR, the only functional changes I made are in canvas.py (related to the drawing/brush functionality). The other CI jobs (builds on macOS, Ubuntu, and Windows) are all passing successfully, so there are no runtime or cross-platform issues.

I’ve just updated my branch to be fully in sync with the latest upstream state to avoid any drift. Based on my local testing and the successful build checks, the feature itself should be stable and mature at this point.

@kirillmeisser
Copy link

Hi, @kancheng thanks for your work! Me and my company would also be very interested in this feature. What is holding it back from being merged? Or do you know why the ci / check job is failing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

3 participants