Ready: WPB-24090 Refactored terraform logic for CD purposes#900
Merged
Conversation
…utions wiab-dev(demo), wiab-staging and default
…input and remove extra cleanup
mohitrajain
changed the title
Veki301
approved these changes
May 13, 2026
Contributor
Veki301
left a comment
Veki301
left a comment
There was a problem hiding this comment.
just a small change needed, otherwise LGTM
|
|
||
| if [[ "$deployment_succeeded" != true ]]; then | ||
| echo "All deployment attempts failed after $MAX_RETRIES tries" | ||
| cleanup |
Contributor
There was a problem hiding this comment.
you already have trap cleanup
* fix: WPB-24090 fixed values for smtp helm chart * Wpb 24090 wiab dev MLS keys 5.25 fixes (#905) * fix: WPB-24090 smtp helm chart name * fix: WPB-24090 enable mls key creation for wiab-dev by default * fix: WPB-24090 add changelog * fix: WPB-24090 update reference for 5.25 to 5.25.21 (#906) * fix: WPB-24090 update reference for 5.25 to 5.25.21 without any pinned component * fix: WPB-24090 remove rust-sft and fluent-bit helm chart to ignore busybox * fix: WPB-24090 added logging in case of helm chart failure * fix: WPB-24090 add a changelog
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed: Refactored terraform logic for CD purposes for all solutions wiab-dev(demo), wiab-staging and default (equivalent). All logic to pick up the region and server type remains in the respective scripts, there will be an iteration over regions first, terraform would just validate the regions and server types
Change type
Basic information
Testing
Offline Build CI (label-based)
Add one or more labels to trigger offline builds:
build-default- Full production build (ansible, terraform, all packages)build-dev- WIAB/dev buildbuild-wiab-staging- WIAB-staging buildbuild-min- Minimal build (fastest, essential charts only)build-all- Run all three buildsNote: No builds run by default. Add a label to trigger CI.
Tracking
changelog.dKnowledge Transfer
Motivation
Objective
Reason
Use case