Skip to content

Refactor skeleton removal logic for media elements in image component #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ElectricKota wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor skeleton removal logic for media elements in image component #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions components/image/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,10 @@ export class Image extends Controller {

if (!element) return

if (element?.complete) this.element.classList.remove('before:skeleton')
else if (element?.oncanplay) element.oncanplay = () => this.element.classList.remove('before:skeleton')
else if (element?.onload) element.onload = () => this.element.classList.remove('before:skeleton')
const removeSkeleton = () => this.element.classList.remove('before:skeleton')

if (element.complete) removeSkeleton()
else if (element instanceof HTMLVideoElement) element.oncanplay = removeSkeleton
else element.onload = removeSkeleton
}
}