feat(atp): build directly from atp source (2/2)#44
Draft
AtomHare wants to merge 8 commits intowinblues:mainfrom
Draft
feat(atp): build directly from atp source (2/2)#44AtomHare wants to merge 8 commits intowinblues:mainfrom
AtomHare wants to merge 8 commits intowinblues:mainfrom
Conversation
|
This seems like a better approach since it uses the upstream install script. This means that build scripts would not need updating for every change in the upstream repo. |
Member
|
It looks like the workflow is failing because of cosign. Try cherry-picking this commit that avoids signing for PRs: 211db0c. |
Author
|
I will split this PR in 2 parts. The first one will only contain everything required to build the apt-common layer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Draft/PR adds support to build atp and export it as a docker layer image. So it can be easily layered on bazzite-dx images.
It uses directly the install process recommended by ATP, so it means less issues in case of an update.
It needs to be discussed but some config files can probably be removed from this repo unless it's wanted to override some default settings for atp.
it may be wanted to remove the default wayland sessions like kinoite7 is doing. => implemented