Skip to content

fix: close websocket cleanly on session id mismatch #1148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gretta-bot wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: close websocket cleanly on session id mismatch #1148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion solara/server/kernel_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,10 @@ def initialize_virtual_kernel(session_id: str, kernel_id: str, websocket: websoc
context = contexts[kernel_id]
if context.session_id != session_id:
logger.critical("Session id mismatch when reusing kernel (hack attempt?): %s != %s", context.session_id, session_id)
websocket.send_text("Session id mismatch when reusing kernel (hack attempt?)")
# Close the websocket cleanly instead of sending plain text.
# The JupyterLab kernel protocol expects all messages to be JSON,
# so sending plain text causes a parse error on the client.
websocket.close()
# to avoid very fast reconnects (we are in a thread anyway)
time.sleep(0.5)
raise ValueError("Session id mismatch")
Expand Down