docs: add description to pyproject.toml#1054
Open
jacklinke wants to merge 1 commit intowidgetti:masterfrom
Open
docs: add description to pyproject.toml#1054jacklinke wants to merge 1 commit intowidgetti:masterfrom
jacklinke wants to merge 1 commit intowidgetti:masterfrom
Conversation
iisakkirotko
requested changes
May 28, 2025
Collaborator
iisakkirotko
left a comment
There was a problem hiding this comment.
Hey @jacklinke! First off, thanks for the PR. I think two things should be addressed before we can merge this:
- As you can see the build fails because
descriptionis listed underdynamicin the pyproject.toml. I don't think it needs to be there, since evidently the value doesn't get added dynamically anywhere (If I'm wrong @maartenbreddels feel free to correct me). - The pyproject.toml in the project root is actually for the package
solara-ui(due to how the project was evolving when we split off thesolarapackage tosolara-ui,solara-server, etc. So I think this description should go to the file found underpackages/solara-meta. I think it would also be good to change this in the other packages in this repo (I think all of them have the same issue), but I understand if you feel that's out of your scope. Let me know!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes to / New Features:
descriptionfield inpyproject.tomlper the Python Packaging User Guide completing Improve display in PyPI Search Display #1053Description of changes
Adding this field will populate the description on PyPI's search page.