Add unit test to that showcases Issue #154#155
Open
saguinav wants to merge 1 commit intowhitlockjc:masterfrom
Open
Add unit test to that showcases Issue #154#155saguinav wants to merge 1 commit intowhitlockjc:masterfrom
saguinav wants to merge 1 commit intowhitlockjc:masterfrom
Conversation
Owner
|
I'll take a peek. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a unit test that showcases Issue #154
While I was writing this unit test I realized that the description I initially provided for this issue was not accurate. The real issue is that when only
filter: ['relative']option is provided the remote references contained by any relative reference are actually being fully resolved. On the other hand, I could successfully verify that remote references that are directly referenced are not being resolved (as expected).To demonstrate this issue, I have added a remote reference inside the test file
test-nested.yamland created a new unit test that expects this remote reference NOT to be resolved.I hope this PR is useful to understand this issue. As I said in the issue I'm opened to contribute with a fix.
Looking forward to your response @whitlockjc
Cheers!