Skip to content

Fix conditional router config attribute error - #145

Merged
AndreRatzenberger merged 1 commit into
mainfrom
cursor/fix-conditional-router-config-attribute-error-5068
Jul 16, 2025
Merged

Fix conditional router config attribute error#145
AndreRatzenberger merged 1 commit into
mainfrom
cursor/fix-conditional-router-config-attribute-error-5068

Conversation

@AndreRatzenberger

Copy link
Copy Markdown
Member

%23%23 馃攧 Pull Request

%23%23%23 Describe your Pull Request
Adds the missing feedback_on_failure field to the ConditionalRouterConfig Pydantic model. This resolves an AttributeError that occurred when the router code attempted to access this undeclared property, ensuring the router can correctly handle feedback messages for failed conditions.


%23%23%23 Is there an existing issue for this%3F

  • Existing Issue

If yes, please specify:

Label/Name of the existing issue (if applicable):
Missing feedback_on_failure attribute in ConditionalRouterConfig


%23%23%23 Please select relevant options:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Improvement

%23%23%23 Checklist

  • My code follows the style guidelines of this project
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Co-authored-by: andre.ratzenberger <andre.ratzenberger@whiteduck.de>
@AndreRatzenberger
AndreRatzenberger merged commit 2b7da9e into main Jul 16, 2025
5 checks passed
@AndreRatzenberger
AndreRatzenberger deleted the cursor/fix-conditional-router-config-attribute-error-5068 branch July 16, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants