Skip to content

Simplify orphan worker closing #12182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
domfarolino wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Simplify orphan worker closing #12182

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c45eb2d
Simplify orphan worker closing
domfarolino Feb 19, 2026
ddd169a
Fix wording
domfarolino Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions source
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130991,8 +130991,8 @@ interface <dfn interface>SharedWorkerGlobalScope</dfn> : <span>WorkerGlobalScope
worker">permissible</span> but not <span data-x="protected worker">protected</span> or <span
data-x="active needed worker">actively needed</span>, if all the <code>Document</code>s in its
transitive set of owners are in <a href="#note-bfcache">bfcache</a>, or if it's a
<code>SharedWorkerGlobalScope</code> with no current owners being kept alive for the duration of
the <span>between-loads shared worker timeout</span>.</p></li>
<code>SharedWorkerGlobalScope</code> whose <span>owner set</span> has been empty so far for less
than the duration of the <span>between-loads shared worker timeout</span>.</p></li>
Copy link
Copy Markdown
Member

@annevk annevk Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this a bit vaguer. Maybe with "so far" dropped it's better?

</ul>
</div>

Expand Down Expand Up @@ -131022,9 +131022,8 @@ interface <dfn interface>SharedWorkerGlobalScope</dfn> : <span>WorkerGlobalScope
follows:</p>

<ul>
<li><p>Workers get <a href="#step-closing-orphan-workers">closed as orphans</a> between when
they stop being <span data-x="protected worker">protected</span> and when they stop being <span
data-x="permissible worker">permissible</span>.</p></li>
<li><p>Workers get <a href="#step-closing-orphan-workers">closed as orphans</a> when they are no
longer <span data-x="protected worker">protected</span>.</p></li>
Copy link
Copy Markdown
Member

@annevk annevk Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this mean that a shared worker cannot be closed as orphan anymore?


<li><p>Workers that have been closed, but keep executing, <a
href="#terminate-rampant-workers">can be terminated</a> at the user agent's discretion, once
Expand Down Expand Up @@ -131263,9 +131262,8 @@ interface <dfn interface>SharedWorkerGlobalScope</dfn> : <span>WorkerGlobalScope
scope</var>.</p>

<li id="step-closing-orphan-workers"><p><i>Closing orphan workers</i>: Start monitoring
<var>worker global scope</var> such that no sooner than it stops being <span data-x="protected
worker">protected</span>, and no later than it stops being <span data-x="permissible
worker">permissible</span>, <var>worker global scope</var>'s <span
<var>worker global scope</var> such that anytime after it stops being <span data-x="protected
worker">protected</span>, <var>worker global scope</var>'s <span
Copy link
Copy Markdown
Member

@annevk annevk Mar 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

data-x="dom-WorkerGlobalScope-closing">closing</span> flag is set to true.</p></li>

<li id="step-suspending-workers"><p><i>Suspending workers</i>: Start monitoring <var>worker
Expand Down