Allow root-level parenthetical expressions in query grammar #4728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restructure test-search.html tests into a clearer hierarchy with descriptive suite names, and improve individual test names.
Notably: * keywords in unexpected locations, * edge-cases around implicit-exists, * nested Q-level queries, * `not` before a Q-level (root) query, and * wrapping Q-level queries in parentheses.
Add negative lookahead to patternExp to prevent reserved keywords (status, path, all, none, etc.) from being used as implicit patterns anywhere in the query grammar. Keywords can still be used when quoted as literal patterns.
Add support for wrapping root-level queries in parentheses (e.g., `(all(...))` or `(exists(...) and path:/foo)`), making the grammar more flexible and allowing better grouping for complex queries.
gsnedders
force-pushed
the
q-level-paren
branch
from
a25c220 to
dc1b550
Compare
Member
Author
|
Ah, this does cause some test regressions if #4729 doesn't precede it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for wrapping root-level queries in parentheses (e.g.,
(all(...))or(exists(...) and path:/foo)), making the grammar more flexible and allowing better grouping for complex queries.This makes complex and/or combinations possible that weren't before, closing a gap in what the query language can express compared with structured queries.
This builds on top of #4727.