Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a regression test to ensure the V8 backend preserves the shared flag on MemoryType when creating a Memory, validating correct type round-tripping via memory.ty(&store).
Changes:
- Add a V8-only unit test that constructs both shared and non-shared memories and asserts
Memory::ty()matches the originalMemoryType.
Contributor
Author
|
Waiting for a new |
syrusakbary
approved these changes
May 5, 2026
Member
syrusakbary
left a comment
syrusakbary
left a comment
There was a problem hiding this comment.
Good to merge once tests pass
Contributor
Author
|
@syrusakbary blocked by your changes to how we build wee8: wasmerio/v8-custom-builds#11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #6121