Skip to content

fix: Declared element section output is hash unstable #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
logan-gatlin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Declared element section output is hash unstable #308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/module/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,11 +408,14 @@ impl Module {
}

// 4. Find undeclared functions and synthesize a Declared element segment.
let undeclared: Vec<_> = ref_funcs
let mut undeclared: Vec<_> = ref_funcs
.iter()
.copied()
.filter(|f| !declared.contains(f))
.collect();
// Sort to ensure we emit the Declared element segment deterministically,
// regardless of IdHashSet iteration order.
undeclared.sort_unstable();
if !undeclared.is_empty() {
log::debug!(
"synthesizing Declared element segment for {} undeclared ref.func references",
Expand Down
Loading