fix(table): use DrawerHeader with close button in preview drawer#76
Merged
pigarevaoks merged 6 commits intomainfrom Apr 3, 2026
Merged
fix(table): use DrawerHeader with close button in preview drawer#76pigarevaoks merged 6 commits intomainfrom
pigarevaoks merged 6 commits intomainfrom
Conversation
Contributor
|
This PR is included in version 0.19.0-rc-feature-fix-table-preview-drawer.1 |
Contributor
|
This PR is included in version 0.19.0-rc-feature-fix-table-preview-drawer.2 |
Contributor
|
This PR is included in version 0.19.0-rc-feature-fix-table-preview-drawer.3 |
Use DrawerHeader and DrawerClose in table preview drawer header instead of custom HStack layout. Extract shared SecurityPreviewContent component with showTitle flag to avoid content duplication. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remove previewTrigger guard from header rendering so renderPreviewHeader works with both master and button triggers. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Change DrawerHeader flex alignment from items-center to items-start so header content aligns to the top when it wraps to multiple lines. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace separate renderPreviewHeader, renderPreviewContent, previewTrigger, previewRowId, and onPreviewRowChange props with a single preview object. Add tooltipText support with 'Open preview' default on master cell for both trigger types. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace flat previewRowId, setPreviewRowId, renderPreviewHeader, renderPreviewContent, previewTrigger, previewTooltipText fields in TableContextValue with a single preview object. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Rename lastPreviewRef to lastContentRef for consistency - Show cursor-pointer on master cell when tooltipText is set (both triggers) - Update JSDoc in usePreviewCell Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
pigarevaoks
force-pushed
the
feature/fix-table-preview-drawer
branch
from
fbee688 to
ae34b67
Compare
Contributor
|
This PR is included in version 0.19.1-rc-feature-fix-table-preview-drawer.1 |
Contributor
|
This PR is included in version 0.19.1 |
Contributor
|
This PR is included in version 0.20.0-rc-feature-add-icons.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DrawerHeader(with built-inDrawerClosebutton) in table preview drawer header instead of custom layoutrenderPreviewHeaderprop to Table for custom drawer headersSecurityPreviewContentcomponent withshowTitleflag to deduplicate preview content between header/no-header variantsTest plan
MasterCellWithActionsstory shows drawer with header + close buttonMasterCellWithPreviewDrawerstory shows drawer with objectName in body (no header)🤖 Generated with Claude Code