feat(table): master cell preview drawer [AS-801]#73
Closed
pigarevaoks wants to merge 4 commits intomainfrom
Closed
feat(table): master cell preview drawer [AS-801]#73pigarevaoks wants to merge 4 commits intomainfrom
pigarevaoks wants to merge 4 commits intomainfrom
Conversation
- Remove preview toggle button, open drawer by clicking master cell - Add controlled mode: `previewRowId` + `onPreviewRowChange` props - DrawerHeader always renders DrawerClose, DrawerTitle only with title - Add MasterCellWithPreviewDrawer story - Fix duplicate DrawerClose (DrawerHeader already includes one) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
This PR is included in version 0.18.1-rc-feature-AS-801-locked-filter-chips.1 |
- Add `previewTrigger` prop: 'master' (click cell) or 'button' (toggle) - Simplify `renderPreviewContent` to return ReactNode (no title) - Extract `usePreviewCell` hook from TableBodyCell - Extract `multiplySecurityEvents` and `renderSecurityPreview` into mocks - Deduplicate stories using shared helpers Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
renderPreviewContentprop on Table — returns{ title?, content }previewRowId+onPreviewRowChangedata-preview-activeDrawerHeaderalways shows close button, title optionalrenderMenuActionin column meta for three-dots menumodalprop added to Drawer componentTest plan
MasterCellWithPreviewDrawerstory works🤖 Generated with Claude Code